Search perf #514

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

dmorilha commented Sep 14, 2012

9/12 by 6:30pm we discovered we should consider a subset of the actual instance as part of the cache key. otherwise things from the request may get included (post parameters, headers, get parameters, etc...)

@@ -541,7 +541,7 @@ YUI.add('mojito-resource-store', function(Y, NAME) {
*/
expandInstanceForEnv: function(env, instance, ctx, cb) {
- var cacheKey = JSON.stringify([instance, ctx]),
+ var cacheKey = JSON.stringify([instance.action, instance.base, action.id, action.type, ctx]),
@imalberto

imalberto Sep 14, 2012

Contributor

instance.base might be undefined ?
"action" is not declared or set within the scope;

Collaborator

caridy commented Sep 14, 2012

@dmorilha @imalberto do we really need this after all? if yes, can you clean it?

Contributor

imalberto commented Sep 14, 2012

This PR has been superceded by PR#517. @dmorilha , can you please close this PR ?

@dmorilha dmorilha closed this Sep 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment