Fix for expandinstace so we dont copy the params object #603

Merged
merged 10 commits into from Nov 6, 2012

Conversation

Projects
None yet
3 participants
@diervo
Contributor

diervo commented Oct 9, 2012

Performance boost!

diervo added some commits Oct 5, 2012

removed lang dependencies from binders.
The langs are already dependencies of the controller so we dont need it
here. It's causing the langs to get deployed always to the client.
@drewfish

This comment has been minimized.

Show comment
Hide comment
@drewfish

drewfish Oct 9, 2012

Contributor

This is missing child.config which is very important I suspect.

Contributor

drewfish commented Oct 9, 2012

This is missing child.config which is very important I suspect.

@diervo

This comment has been minimized.

Show comment
Hide comment
@diervo

diervo Oct 9, 2012

Contributor

This is a Ric and I fix for avoid the overhead of copying the params. It seems that is working fine..
It was never there in the first place...

Contributor

diervo commented Oct 9, 2012

This is a Ric and I fix for avoid the overhead of copying the params. It seems that is working fine..
It was never there in the first place...

@diervo

This comment has been minimized.

Show comment
Hide comment
@diervo

diervo Oct 9, 2012

Contributor

This is input to the composite addon, and in the docs seems that we dont need the config at all. It only mention params:

cfg = {
    children: {
        slot-1: {
            type: "default",
            action: "index"
        },
        slot-2: {
            type: "default",
            action: "index",
            params: {
                route: {},
                url: {},
                body: {},
                file: {}
            }
        }
    },
    assets: {}
}
Contributor

diervo commented Oct 9, 2012

This is input to the composite addon, and in the docs seems that we dont need the config at all. It only mention params:

cfg = {
    children: {
        slot-1: {
            type: "default",
            action: "index"
        },
        slot-2: {
            type: "default",
            action: "index",
            params: {
                route: {},
                url: {},
                body: {},
                file: {}
            }
        }
    },
    assets: {}
}
@drewfish

This comment has been minimized.

Show comment
Hide comment
@drewfish

drewfish Oct 9, 2012

Contributor

I think child.config is needed by other users.

Contributor

drewfish commented Oct 9, 2012

I think child.config is needed by other users.

@diervo

This comment has been minimized.

Show comment
Hide comment
@diervo

diervo Oct 9, 2012

Contributor

I just added the config to the PR :)

Contributor

diervo commented Oct 9, 2012

I just added the config to the PR :)

@caridy caridy merged commit a01d12a into YahooArchive:develop-perf Nov 6, 2012

1 check failed

default The Travis build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment