pathToRoot should be dynamic rather than static config #613

Merged
merged 1 commit into from Oct 11, 2012

Conversation

Projects
None yet
2 participants
@caridy
Collaborator

caridy commented Oct 11, 2012

adding config addon into url to make sure that pathToRoot can be customized per context.

adding config addon into url to make sure that pathToRoot can be cust…
…omized per context, and also allow Search addon to override url addon using the same namespace
@caridy

This comment has been minimized.

Show comment
Hide comment
@caridy

caridy Oct 11, 2012

Collaborator

@imalberto can u review this?

Collaborator

caridy commented Oct 11, 2012

@imalberto can u review this?

@imalberto

This comment has been minimized.

Show comment
Hide comment
@imalberto

imalberto Oct 11, 2012

Contributor

NOTE: that now the url addon is reading the appConfig from the contextualized and not the static config anymore to address html5app that are built with a specific context.
+1

Contributor

imalberto commented Oct 11, 2012

NOTE: that now the url addon is reading the appConfig from the contextualized and not the static config anymore to address html5app that are built with a specific context.
+1

caridy added a commit that referenced this pull request Oct 11, 2012

Merge pull request #613 from caridy/url-addon-hack
- fix: appConfig.pathToRoot should be dynamic rather than static config

@caridy caridy merged commit 135ed5a into YahooArchive:develop-perf Oct 11, 2012

1 check failed

default The Travis build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment