Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix start logic. #628

merged 8 commits into from Oct 14, 2012


None yet
3 participants

mojit0 commented Oct 13, 2012

Fix startup logic to support broader range of containers and broken container startup issues.

mojit0 added some commits Oct 13, 2012

@mojit0 mojit0 Fix intermittently failing functional test.
This test's comparison on hours would consistently fail…if it was 12:xx on the clock, otherwise it would pass.
@mojit0 mojit0 Add missing portion of test fix.
Adjust the logic to not produce a 0:xx pm value.
@mojit0 mojit0 Fix start logic.
Adjusted MojitoServer to remove start() call and replace with listen(). This
provides a more flexible way to adapt to different hosting container needs.

Adjust archetype server.js files to provide more information/templates.
@mojit0 mojit0 Fix index.js archetypes.
The index.js archetypes were still reflecting the pre-clean-startup version.
@mojit0 mojit0 Fix host defaulting.
Defaulting the host wasn't working properly. Adjusted to support putting in an explicit host, otherwise don't use one at all.

add0n commented on edac5b7 Oct 13, 2012


Is this manhattan friendly? this was in index.js before, and that one was not used at all by manhattan.


caridy commented Oct 13, 2012

Let's just make sure we document this and provide an easy way to upgrade. Probably a good opportunity to introduce mojito upgrade command to facilitate this type of changes in the future.

@mojit0 mojit0 Adjust index/server coordination for container startup.
The index.js file is key for some containers so redirected it to call in server.js rather than mojito module.

mojit0 commented Oct 13, 2012

@caridy The whole point is to make it Manhattan friendly :) I've tested it with the latest changes and it seems stable now with Manhattan deployment uncommented in the server.js file. The release notes for the proposed 0.4.7 will have to point to updating both the index.js and server.js files in any applications which are using the older versions.

@mojit0 mojit0 added a commit that referenced this pull request Oct 14, 2012

@mojit0 mojit0 Merge pull request #628 from mojit0/develop
Fix start logic.

@mojit0 mojit0 merged commit 89c248e into YahooArchive:develop Oct 14, 2012

1 check passed

default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment