Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Clean up of expanded instance #646

Merged
merged 9 commits into from Oct 22, 2012

Conversation

Projects
None yet
2 participants
Collaborator

caridy commented Oct 18, 2012

  • remove loader configuration from expanded instance
  • clean boot process
  • remove deprecated instance.guid
  • fix client side to work with the new loader

@drewfish drewfish commented on an outdated diff Oct 22, 2012

lib/store.server.js
@@ -826,8 +826,18 @@ YUI.add('mojito-resource-store', function(Y, NAME) {
ress = this.getResourceVersions({mojit: mojit});
for (r = 0; r < ress.length; r += 1) {
res = ress[r];
- if (res.yui && res.yui.name) {
+ // exposing YUI modules with common or client affinity.
+ // TODO: this should be handled differently, asking for
+ // the specific resources with the correct affinity.
+ if (res.yui && res.yui.name && res.affinity &&
@drewfish

drewfish Oct 22, 2012

Contributor

Since a single resource can have both.common. and .client. versions, I think this needs to be done differently. I think we should first walk common version, then walk client versions, so that the metadata about client version clobbers (has higher priority than) metadata about common versions.

Actually, this shouldn't be "common and client" but instead "common and env (current runtime)".

Contributor

drewfish commented Oct 22, 2012

+1

caridy added a commit that referenced this pull request Oct 22, 2012

Merge pull request #646 from caridy/instance-cleanup
Clean up of expanded instance:

- remove loader configuration from expanded instance
- clean boot process
- remove deprecated instance.guid
- fix client side to work with the new loader

@caridy caridy merged commit 8fb956f into YahooArchive:develop-perf Oct 22, 2012

1 check failed

default The Travis build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment