optimizing the cache key for instances by relying on type and base only #720

Merged
merged 1 commit into from Nov 8, 2012

Conversation

Projects
None yet
2 participants
@caridy
Collaborator

caridy commented Nov 8, 2012

this should fix any memory allocation when using id as part of the instance object before expanding it. also, shaker does not use action anymore, so we are removing it.

optimizing the cache key for instances by relying on type and base on…
…ly. this should fix any memory allocation when using id as part of the instance object before expanding it. also, shaker does not use action anymore, so we are removing it.
@drewfish

This comment has been minimized.

Show comment Hide comment
@drewfish

drewfish Nov 8, 2012

Contributor

+1

Contributor

drewfish commented Nov 8, 2012

+1

caridy added a commit that referenced this pull request Nov 8, 2012

Merge pull request #720 from caridy/expand-hash
fix to optimize the cache key for instances by relying on type and base only, this will fix any memory allocation when using id as part of the instance object before expanding it. also, shaker does not use action anymore, so it is safe to remove it.

@caridy caridy merged commit a62778c into YahooArchive:develop-perf Nov 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment