Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

do not colorize test.js output if there is no tty [gh809,bz5964521] #872

Merged
merged 11 commits into from Jan 4, 2013

Conversation

Projects
None yet
2 participants
Contributor

isao commented Jan 3, 2013

  • use process.*.isTTY instead of require('tty').istty()
  • tested on node 0.6, 0.8
  • n.b. some app and addon Y.log() messages remain tty unaware.

isao added some commits Jan 3, 2013

@isao isao lint 667f4a1
@isao isao rm unused testStart var 75405e4
@isao isao minor, re-arrange for consistency 28c2563
@isao isao rm dead fw test code 62d396c
@isao isao minor a7c45c8
@isao isao do not colorize test.js output if there is no tty.
use process.*.isTTY instead of require('tty').istty()
tested on node 0.6, 0.8; n.b. some app and addon
Y.log() messages remain tty unaware.

fix issue 809
fix bz 5964521
1541e13

@mojit0 mojit0 and 1 other commented on an outdated diff Jan 3, 2013

lib/app/commands/test.js
@@ -4,7 +4,7 @@
* See the accompanying LICENSE file for terms.
*/
-/*jslint anon:true, regexp:true, nomen:true, stupid:true*/
+/*jslint anon:true, regexp:true, nomen:true, stupid:true node:true*/
@mojit0

mojit0 Jan 3, 2013

Contributor

comma after stupid:true ?

@isao

isao Jan 3, 2013

Contributor

interesting looks like the jslint I have and jslint.com don't care about the comma in the config. I'll add it for consistency

Contributor

mojit0 commented Jan 3, 2013

+1

@isao isao added a commit that referenced this pull request Jan 4, 2013

@isao isao Merge pull request #872 from isao/testjs
do not colorize test.js output if there is no tty [gh809,bz5964521]
78a50ab

@isao isao merged commit 78a50ab into YahooArchive:develop Jan 4, 2013

1 check passed

default The Travis build passed
Details

@isao isao deleted the isao:testjs branch Jan 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment