moving part of the logic from HTMLFrame to mojito-frame-addon #926

Merged
merged 7 commits into from Jan 19, 2013

Conversation

Projects
None yet
3 participants
@caridy
Collaborator

caridy commented Jan 15, 2013

The idea here is to make the creation of Frames Mojits a breeze.

Based on the current implementation we can create a mojit that inherit from HTMLFrameMojit or just create a brand new that uses a set of addons to create a frame. In this gist I demonstrated both approaches:

Todo:

  • Document re-usability of the HTMLFrameMojit methods (this is for Joe)
@drewfish

This comment has been minimized.

Show comment Hide comment
@drewfish

drewfish Jan 15, 2013

Contributor

Perhaps instead move the asset management stuff (renderListAsHtmlAssets() etc) into the "assets" AC addon. That way you (perhaps) don't need a new AC addon.

Contributor

drewfish commented Jan 15, 2013

Perhaps instead move the asset management stuff (renderListAsHtmlAssets() etc) into the "assets" AC addon. That way you (perhaps) don't need a new AC addon.

@caridy

This comment has been minimized.

Show comment Hide comment
@caridy

caridy Jan 18, 2013

Collaborator

Tests are still unstable, one of jobs passed, the other fail here:

Failed Common: simplemodelclient onMozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0
Passed, 1 Failed , 0 skipped
in testCase_yui_3_7_3_2_1358546278029_33
test simplemodelclient:Unexpected error: Y.one(...) is null

I did a manual verification, and it works just fine. Seems like a timer issue in Arrow.

Anyway, this is ready for review!

Collaborator

caridy commented Jan 18, 2013

Tests are still unstable, one of jobs passed, the other fail here:

Failed Common: simplemodelclient onMozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0
Passed, 1 Failed , 0 skipped
in testCase_yui_3_7_3_2_1358546278029_33
test simplemodelclient:Unexpected error: Y.one(...) is null

I did a manual verification, and it works just fine. Seems like a timer issue in Arrow.

Anyway, this is ready for review!

@caridy caridy referenced this pull request Jan 18, 2013

Closed

HTMLFrameMojit enhancements #353

@isao

This comment has been minimized.

Show comment Hide comment
@isao

isao Jan 19, 2013

Contributor

+1

Contributor

isao commented Jan 19, 2013

+1

caridy added a commit that referenced this pull request Jan 19, 2013

Merge pull request #926 from caridy/frame-addon
moving part of the logic from HTMLFrame into assets addon to facilitate customization of the frame:

- Add support for inheritance over HTMLFrameMojit or just create a brand new frame that uses a set of addons to create a frame. In this gist I demonstrated both approaches: https://gist.github.com/4543247

@caridy caridy merged commit 5931754 into YahooArchive:develop Jan 19, 2013

1 check passed

default The Travis build passed
Details

@caridy caridy deleted the caridy:frame-addon branch Jan 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment