Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
moving part of the logic from HTMLFrame to mojito-frame-addon #926
The idea here is to make the creation of Frames Mojits a breeze.
Based on the current implementation we can create a mojit that inherit from HTMLFrameMojit or just create a brand new that uses a set of addons to create a frame. In this gist I demonstrated both approaches:
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Tests are still unstable, one of jobs passed, the other fail here:
Failed Common: simplemodelclient onMozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0
I did a manual verification, and it works just fine. Seems like a timer issue in Arrow.
Anyway, this is ready for review!