Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output - when count rules's output has no content #1347

Merged
merged 2 commits into from
May 18, 2024

Conversation

fukusuket
Copy link
Collaborator

@fukusuket fukusuket commented May 18, 2024

What Changed

I would like to implement #1324 by dividing it into several PRs. First, I modified it to output "-" to console.
First implement the following: Related #1342

    1. ExtraFieldInfo is blank (··) but would nice to have it as - which we use for n/a. So ·· -> · - ·

Evidence

I confirmed that hyphens are output as shown below.

This PR:

% ./hayabusa csv-timeline -d ../hayabusa-sample-evtx -r test2.yml -w -q
Start time: 2024/05/18 13:08
...
Timestamp · RuleTitle · Level · Computer · Channel · EventID · RecordID · Details · ExtraFieldInfo
2016-09-20 01:50:06.477 +09:00 · TEST_TITLE · info · - · - · - · - · Count: 3561 ¦ IpAddress: 192.168.198.149 · -
2021-10-24 06:50:11.666 +09:00 · TEST_TITLE · info · - · - · - · - · Count: 2 ¦ IpAddress: 10.23.23.9 · -

2.15.0:

% ./hayabusa-2.15.0-mac-aarch64 csv-timeline -d ../hayabusa-sample-evtx -r test2.yml -w -q
Start time: 2024/05/18 13:09
...
Timestamp · RuleTitle · Level · Computer · Channel · EventID · RecordID · Details · ExtraFieldInfo
2016-09-20 01:50:06.477 +09:00 · TEST_TITLE · info · - · - · - ·  · [condition] count() by IpAddress >= 2 in timeframe [result] count: 3561 IpAddress:192.168.198.149 timeframe:5d ·
2021-10-24 06:50:11.666 +09:00 · TEST_TITLE · info · - · - · - ·  · [condition] count() by IpAddress >= 2 in timeframe [result] count: 2 IpAddress:10.23.23.9 timeframe:5d ·

I would appreciate it if you could check it out when you have time🙏

@fukusuket fukusuket self-assigned this May 18, 2024
@fukusuket fukusuket added the enhancement New feature or request label May 18, 2024
@fukusuket fukusuket added this to the v2.16.0 milestone May 18, 2024
@fukusuket fukusuket marked this pull request as ready for review May 18, 2024 04:15
@fukusuket fukusuket marked this pull request as draft May 18, 2024 04:19
@fukusuket fukusuket marked this pull request as ready for review May 18, 2024 04:40
Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket LGTM! Thanks!

@YamatoSecurity YamatoSecurity merged commit 69b7793 into main May 18, 2024
5 checks passed
@YamatoSecurity YamatoSecurity deleted the 1342-output-hyphen-when-no-content branch May 18, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants