Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better encapsulation and safety guarantee for Entries #14

Merged
merged 3 commits into from
Feb 25, 2023

Conversation

YaxinCheng
Copy link
Owner

  • Functions in Entry is safe now because only the latest Entry will be accessible.
    • In the non-lending-iter feature scenario, every Entry is passed into a callback closure as mutable references. This prevents the Entrys from being moved out of the closure.
    • In the lending-tier feature scenario, the lending iterator guarantees the references cannot be moved.
  • Reading an entry file content more than once will silently return. This matches with the behaviour when reading a file from EOF.

@YaxinCheng YaxinCheng changed the title Better encapsulation and safety guarantee for Entries Better encapsulation and safety guarantee for Entries Feb 25, 2023
@YaxinCheng YaxinCheng merged commit ac87c4c into master Feb 25, 2023
@YaxinCheng YaxinCheng deleted the closure_entries branch February 25, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant