Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean all potentially panicking unwraps #4

Conversation

Projects
None yet
2 participants
@travismiller
Copy link
Contributor

commented Aug 21, 2018

Here's my attempt at this for #3 !

The crux is leveraging the failure crate.

I was not able to eliminate unwrap in the following:

  • DocumentCollection::index
  • DocumentCollection::index_mut
  • Model::from_document
  • Model::to_document
  • All instances of unwrap in tests remain

Additionally, I was not able to figure out how to run all the tests as they seemed to be interfering with each other. So, each test uses it's own database.

Feedback and modifications welcome! 馃榾

@OtaK OtaK self-requested a review Aug 23, 2018

@OtaK

This comment has been minimized.

Copy link
Member

commented Aug 23, 2018

Thanks for the PR!
I'll check it out ASAP and review it :)

Very good ideas on using failure and keeping a changelog, it was very much needed 馃憤

@OtaK

OtaK approved these changes Aug 23, 2018

@OtaK OtaK merged commit 03b9e21 into YellowInnovation:master Aug 23, 2018

@OtaK

This comment has been minimized.

Copy link
Member

commented Aug 23, 2018

Amazing PR, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.