initial version of dateglob module #1

Merged
merged 16 commits into from Jun 14, 2011

Conversation

Projects
None yet
3 participants
Collaborator

davidmarin commented Jun 14, 2011

Are either of you up for reviewing this? This module will allow us to send more than 3 or so months of logs to MRJobs.

harleyk commented Jun 14, 2011

Don't make everything private by prefixing everything with _. Use __all__ to do the same thing and remove all the underscores. All those underscores make everything ugly. Other than that, looks great.

David Marin Merge pull request #1 from Roguelazer/master
improve packaging
2538670
Collaborator

davidmarin commented Jun 14, 2011

Okay, will do. Thanks, Julian.

@davidmarin davidmarin pushed a commit that referenced this pull request Jun 14, 2011

David Marin Merge pull request #1 from davidmarin/master
initial version of dateglob module
38ce46f

@davidmarin davidmarin merged commit 38ce46f into Yelp:master Jun 14, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment