From d713ca652c3a34848d923d4b5d18e33561baa628 Mon Sep 17 00:00:00 2001 From: QSilver Date: Thu, 19 May 2022 08:54:13 +0100 Subject: [PATCH 1/2] Addressing issue 552: https://github.com/Yelp/detect-secrets/issues/552 Improving performance for array slice --- detect_secrets/util/code_snippet.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/detect_secrets/util/code_snippet.py b/detect_secrets/util/code_snippet.py index 4c61df6ed..7d10ada25 100644 --- a/detect_secrets/util/code_snippet.py +++ b/detect_secrets/util/code_snippet.py @@ -27,7 +27,7 @@ def get_code_snippet( target_line_index = lines_of_context return CodeSnippet( - snippet=list(itertools.islice(lines, start_line_index, end_line_index)), + snippet=lines[start_line_index:end_line_index], start_line=start_line_index, target_index=target_line_index, ) From 8c2374695d67e61b34c13a7ebc7cfa9c0574e8dc Mon Sep 17 00:00:00 2001 From: QSilver Date: Thu, 19 May 2022 18:34:31 +0100 Subject: [PATCH 2/2] Removing unused import --- detect_secrets/util/code_snippet.py | 1 - 1 file changed, 1 deletion(-) diff --git a/detect_secrets/util/code_snippet.py b/detect_secrets/util/code_snippet.py index 7d10ada25..740bc4271 100644 --- a/detect_secrets/util/code_snippet.py +++ b/detect_secrets/util/code_snippet.py @@ -1,4 +1,3 @@ -import itertools from typing import Generator from typing import List