Skip to content

Commit

Permalink
Merge pull request #1881 from davidmarin/deprecate-interpreter
Browse files Browse the repository at this point in the history
Deprecate interpreter and steps_interpreter opts (fixes #1850)
  • Loading branch information
David Marin committed Nov 9, 2018
2 parents 14d7282 + 8e4a962 commit 995effc
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 7 deletions.
20 changes: 13 additions & 7 deletions docs/guides/configs-all-runners.rst
Expand Up @@ -42,7 +42,8 @@ options related to file uploading.
:default: (automatic)

Should we automatically zip up the mrjob library and install it when we run
job? By default, we do unless :mrjob-opt:`interpreter` is set.
job? By default, we do unless :mrjob-opt:`interpreter` (deprecated)
is set.

Set this to ``False`` if you've already installed ``mrjob`` on your
Hadoop cluster or install it by some other method.
Expand Down Expand Up @@ -278,6 +279,10 @@ Job execution context
:set: all
:default: ``None``

.. deprecated:: 0.6.7

support for non-Python jobs is being phased out.

Non-Python command to launch your script with (e.g. ``'ruby'``).
This will also be used to query the script about steps unless you set
:mrjob-opt:`steps_interpreter`.
Expand Down Expand Up @@ -305,12 +310,9 @@ Job execution context

This option also affects which Python binary is used for file locking in
:mrjob-opt:`setup` scripts, so it might be useful to set even if you're
using a non-Python :mrjob-opt:`interpreter`. It's also used by
:py:class:`~mrjob.emr.EMRJobRunner` to compile mrjob after bootstrapping it
(see :mrjob-opt:`bootstrap_mrjob`).

Unlike :mrjob-opt:`interpreter`, this does not affect the binary used to
query the job about its steps (use :mrjob-opt:`steps_python_bin`).
using a non-Python :mrjob-opt:`interpreter` (deprecated). It's also
used by :py:class:`~mrjob.emr.EMRJobRunner` to compile mrjob after
bootstrapping it (see :mrjob-opt:`bootstrap_mrjob`).

.. mrjob-opt::
:config: setup
Expand Down Expand Up @@ -389,6 +391,10 @@ Job execution context
:set: all
:default: current Python interpreter

.. deprecated:: 0.6.7

support for non-Python jobs is being phased out.

Alternate (non-Python) command to use to query the job about
its steps. Usually it's good enough to set :mrjob-opt:`interpreter`.

Expand Down
2 changes: 2 additions & 0 deletions mrjob/options.py
Expand Up @@ -814,6 +814,7 @@ def __call__(self, parser, namespace, value, option_string=None):
),
interpreter=dict(
combiner=combine_cmds,
deprecated=True,
switches=[
(['--interpreter'], dict(
help='Non-python command to run your script, e.g. "ruby".',
Expand Down Expand Up @@ -1212,6 +1213,7 @@ def __call__(self, parser, namespace, value, option_string=None):
),
steps_interpreter=dict(
combiner=combine_cmds,
deprecated=True,
switches=[
(['--steps-interpreter'], dict(
help=("Non-Python command to use to query the job about its"
Expand Down

0 comments on commit 995effc

Please sign in to comment.