From 0a430e7b21494c14d70ee98f27b01fb939a2b328 Mon Sep 17 00:00:00 2001 From: Dave Marin Date: Fri, 9 Nov 2018 13:40:04 -0800 Subject: [PATCH 1/2] deprecate interpreter and steps_intepreter --- mrjob/options.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mrjob/options.py b/mrjob/options.py index 3fafa12f1..1c5ed2981 100644 --- a/mrjob/options.py +++ b/mrjob/options.py @@ -814,6 +814,7 @@ def __call__(self, parser, namespace, value, option_string=None): ), interpreter=dict( combiner=combine_cmds, + deprecated=True, switches=[ (['--interpreter'], dict( help='Non-python command to run your script, e.g. "ruby".', @@ -1212,6 +1213,7 @@ def __call__(self, parser, namespace, value, option_string=None): ), steps_interpreter=dict( combiner=combine_cmds, + deprecated=True, switches=[ (['--steps-interpreter'], dict( help=("Non-Python command to use to query the job about its" From 8981f051c332be39685f26865837b6eeae47e20f Mon Sep 17 00:00:00 2001 From: Dave Marin Date: Fri, 9 Nov 2018 13:52:47 -0800 Subject: [PATCH 2/2] noted that interpreter opt is deprecated in docs --- docs/guides/configs-all-runners.rst | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/docs/guides/configs-all-runners.rst b/docs/guides/configs-all-runners.rst index 112bc80da..1e04c6b1c 100644 --- a/docs/guides/configs-all-runners.rst +++ b/docs/guides/configs-all-runners.rst @@ -42,7 +42,8 @@ options related to file uploading. :default: (automatic) Should we automatically zip up the mrjob library and install it when we run - job? By default, we do unless :mrjob-opt:`interpreter` is set. + job? By default, we do unless :mrjob-opt:`interpreter` (deprecated) + is set. Set this to ``False`` if you've already installed ``mrjob`` on your Hadoop cluster or install it by some other method. @@ -278,6 +279,10 @@ Job execution context :set: all :default: ``None`` + .. deprecated:: 0.6.7 + + support for non-Python jobs is being phased out. + Non-Python command to launch your script with (e.g. ``'ruby'``). This will also be used to query the script about steps unless you set :mrjob-opt:`steps_interpreter`. @@ -305,12 +310,9 @@ Job execution context This option also affects which Python binary is used for file locking in :mrjob-opt:`setup` scripts, so it might be useful to set even if you're - using a non-Python :mrjob-opt:`interpreter`. It's also used by - :py:class:`~mrjob.emr.EMRJobRunner` to compile mrjob after bootstrapping it - (see :mrjob-opt:`bootstrap_mrjob`). - - Unlike :mrjob-opt:`interpreter`, this does not affect the binary used to - query the job about its steps (use :mrjob-opt:`steps_python_bin`). + using a non-Python :mrjob-opt:`interpreter` (deprecated). It's also + used by :py:class:`~mrjob.emr.EMRJobRunner` to compile mrjob after + bootstrapping it (see :mrjob-opt:`bootstrap_mrjob`). .. mrjob-opt:: :config: setup @@ -389,6 +391,10 @@ Job execution context :set: all :default: current Python interpreter + .. deprecated:: 0.6.7 + + support for non-Python jobs is being phased out. + Alternate (non-Python) command to use to query the job about its steps. Usually it's good enough to set :mrjob-opt:`interpreter`.