From f1fac49ec3dd0e90e5e74686ceb415ff4ccef67e Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Tue, 4 Feb 2020 22:12:18 +0100 Subject: [PATCH 1/2] Update make test to run pre-commit hooks on the whole codebase --- Makefile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 3746be19..e0910c5c 100644 --- a/Makefile +++ b/Makefile @@ -11,12 +11,16 @@ regenerate-samples: ${CURDIR}/gradlew plugin:publishToMavenLocal ${CURDIR}/gradlew generateSwagger -test: +run-hooks: install-hooks + ${CURDIR}/venv/bin/pre-commit run --all-files + +test: run-hooks ${CURDIR}/gradlew plugin:build ${CURDIR}/gradlew plugin:publishToMavenLocal ${CURDIR}/gradlew generateSwagger ${CURDIR}/gradlew assembleDebug ${CURDIR}/gradlew check + deactivate venv: virtualenv venv From aeb2192b068520fed29a3981b8aecacad75f3ec3 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Tue, 4 Feb 2020 22:17:41 +0100 Subject: [PATCH 2/2] Update run-hooks to depend on venv --- Makefile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index e0910c5c..8f7cb125 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,4 @@ -.PHONY: install-hooks regenerate-samples test +.PHONY: install-hooks regenerate-samples test run-hooks .git/hooks/pre-commit: venv ${CURDIR}/venv/bin/pre-commit install --install-hooks @@ -11,7 +11,7 @@ regenerate-samples: ${CURDIR}/gradlew plugin:publishToMavenLocal ${CURDIR}/gradlew generateSwagger -run-hooks: install-hooks +run-hooks: venv ${CURDIR}/venv/bin/pre-commit run --all-files test: run-hooks @@ -20,7 +20,6 @@ test: run-hooks ${CURDIR}/gradlew generateSwagger ${CURDIR}/gradlew assembleDebug ${CURDIR}/gradlew check - deactivate venv: virtualenv venv