Fixed System.read function #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to have to rollback the last commit. Now I realise why Dan200 writes mods and I don't! |
|
Why port over the entire function? You should just cast the parameters and pass them to the native function. |
This reverts commit 619c6b8.
|
The read function relies on os.pullEvent. This doesn't appear to work in SEE (this is the same reason Rednet doesn't work) and so needs to be ported . |
|
Ah, I see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is a re-implementation of the read function from bios.lua. Supports replacement characters, history, paste etc...