Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-Game: Ellipse collision type does not register collisions inside the bbox but outside the sprite bounds #5468

Closed
danielpancake opened this issue Apr 12, 2024 — with GM Bug Reporter · 2 comments
Closed

In-Game: Ellipse collision type does not register collisions inside the bbox but outside the sprite bounds #5468

danielpancake opened this issue Apr 12, 2024 — with GM Bug Reporter · 2 comments
Assignees
@jackerley
Labels
project This issue has a sample project attached runner-bug In-game bugs with the "GameMaker Studio 2" runtimes
Milestone
2024.6

Comments

@danielpancake
Copy link

Description

Collision event ignores the part of the ellipse collision bbox outside of the sprite bounds which is not the case for the rectangle bbox

Steps To Reproduce

Create a sprite and put an ellipse collision bbox outside of the sprite bounds

Which version of GameMaker are you reporting this issue for?

IDE v2024.2.0.132 Runtime v2024.2.0.163

Which operating system(s) are you seeing the problem on?

Windows 10.0.22631.0

cee9f336-4557-46ca-9f9f-0367465871be
@gm-bug-reporter gm-bug-reporter bot added runner-bug In-game bugs with the "GameMaker Studio 2" runtimes project This issue has a sample project attached labels Apr 12, 2024
@stuckie stuckie added this to the 2024.6 milestone Apr 15, 2024
jackerley added a commit to YoYoGames/GameMaker-HTML5 that referenced this issue May 23, 2024
@jackerley
[Collisions] Moving to using image bound rather than image
3558f65 
size for the size of the collision mask

YoYoGames/GameMaker-Bugs#5468
@jackerley jackerley mentioned this issue May 23, 2024
Merged
@jackerley
Copy link

The fix for this was rather complicated. Essentially all precise collision masks have moved over to being stored per sprite bounding box rather than per sprite size. This has impacted a number of functions so I've tested with a number of test projects which I'll attach here. This does have the benefit of reducing memory usage for precise collisions, so has benefits beyond just this specific bug.
testprojects.zip

@YYDan YYDan added the documentation Improvements or additions to documentation are required by this issue label May 23, 2024
@YYDan YYDan changed the title Ellipse collision bbox does not work outside the sprite bounds In-Game: Ellipse collision type does not register collisions inside the bbox but outside the sprite bounds May 23, 2024
@gurpreetsinghmatharoo gurpreetsinghmatharoo removed the documentation Improvements or additions to documentation are required by this issue label Jun 6, 2024
@mgeddesGM
Copy link

verified as of v2024.600.0.568 Runtime v2024.600.0.595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackerley jackerley

Labels
project This issue has a sample project attached runner-bug In-game bugs with the "GameMaker Studio 2" runtimes
Projects
Team Workload
Status: Verified
Milestone
2024.6
Development

No branches or pull requests
6 participants
@stuckie @jackerley @YYDan @gurpreetsinghmatharoo @danielpancake @mgeddesGM