Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippet preview/score bar overlapping other functionality using the PageLayoutHeader hook #324

Open
patrickbroens opened this issue Mar 6, 2020 · 0 comments

Comments

@patrickbroens
Copy link

@patrickbroens patrickbroens commented Mar 6, 2020

The score bar on top of the snippet preview, rendered in the page module using the PageLayoutHeader hook, is having a negative margin. When adding other functionality to the PageLayoutHeader hook, above the score bar and snippet preview, the score bar is interfering with the other functionality, because it is forced up with the following CSS

.yoast-seo-score-bar {
    margin-top: -15px;
}

The negative margin should be removed here, so it does not overlap the other added functionality. Other functionality using the same hook should not be forced to add extra margins because of the Yoast SEO score bar.

How can we reproduce this behavior?

  1. Make some functionality using the PageLayoutHeader hook and make sure it is loaded before the Yoast page layout header. In CSS make sure the content of the outer container stays inside the container.
  2. Check that the 'score-bar' is overlapping the container mentioned before

Technical info

  • TYPO3 version: 9.5
  • Yoast SEO version: 5.1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.