Whip_WPMessageDismissListener::listen(): bug fix #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Whip_MessageDismisser::verifyNonce()` method expects to be passed a `string`, but if the nonce was not available, it would be passed `null`, which could lead to PHP 8.1 "passing null to non-nullable" deprecation notices (though in this case wouldn't as the underlying [`wp_verify_nonce()`](https://developer.wordpress.org/reference/functions/wp_verify_nonce/) function casts the value to string anyway). All the same, it is a bug. Fixed now. Note: as the test suite does not test with a real WP setup, this bug currently cannot easily be safeguarded via a test. The `WHIP_WPMessageDismissListener::listen()` method does have tests, but mocks away the `Whip_MessageDismisser::verifyNonce()` method, so the mock was hiding the bug.
Pull Request Test Coverage Report for Build 6312604562
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Whip_MessageDismisser::verifyNonce()method expects to be passed astring, but if the nonce was not available, it would be passednull, which could lead to PHP 8.1 "passing null to non-nullable" deprecation notices (though in this case wouldn't as the underlyingwp_verify_nonce()function casts the value to string anyway).All the same, it is a bug. Fixed now.
Note: as the test suite does not test with a real WP setup, this bug currently cannot easily be safeguarded via a test.
The
WHIP_WPMessageDismissListener::listen()method does have tests, but mocks away theWhip_MessageDismisser::verifyNonce()method, so the mock was hiding the bug./cc @vraja-pro