PHP 7.4 compatibility fix / implode argument order #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`implode()` takes two parameters, `$glue` and `$pieces`. For historical reasons, `implode()` accepted these parameters in either order, though it was recommended to use the documented argument order of `implode( $glue, $pieces )`. PHP 7.4 deprecates the tolerance for passing the parameters for `implode()` in reverse order. PHP 8.0 is expected to remove the tolerance for this completely. Refs: * https://wiki.php.net/rfc/deprecations_php_7_4#implode_parameter_order_mix * https://php.net/manual/en/function.implode.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implode()takes two parameters,$glueand$pieces.For historical reasons,
implode()accepted these parameters in either order, though it was recommended to use the documented argument order ofimplode( $glue, $pieces ).PHP 7.4 deprecates the tolerance for passing the parameters for
implode()in reverse order.PHP 8.0 is expected to remove the tolerance for this completely.
Refs:
Verifying this fix
I've turned on a build against
master: https://travis-ci.org/Yoast/whip/jobs/565998239As you can see, the Travis builds on PHP 7.4 are failing. This is caused by the above issue.
When you look at the Travis output for this PR - https://travis-ci.org/Yoast/whip/jobs/565996627 -, you will see that the PHP 7.4 build is passing again.