From 72c241ee2221776ba61e4e2bfe1df6f97e9acb9a Mon Sep 17 00:00:00 2001
From: Enrico Battocchi <enrico.battocchi@gmail.com>
Date: Fri, 3 May 2024 08:33:17 +0200
Subject: [PATCH] Exclude
 `VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable` for
 deprecated code

---
 .phpcs.xml.dist | 6 ++++++
 composer.json   | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/.phpcs.xml.dist b/.phpcs.xml.dist
index c71ab7fe143..6209556d799 100644
--- a/.phpcs.xml.dist
+++ b/.phpcs.xml.dist
@@ -227,6 +227,12 @@
 		<exclude-pattern>/inc/wpseo-functions-deprecated\.php$</exclude-pattern>
 	</rule>
 
+	<!-- Ignore unused variables in deprecated functionality. -->
+	<rule ref="VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable">
+		<exclude-pattern>/src/deprecated/*</exclude-pattern>
+		<exclude-pattern>/inc/wpseo-functions-deprecated\.php$</exclude-pattern>
+	</rule>
+
 	<!-- Exclude deprecated code from select sniffs regarding naming conventions.
 		 These classes are still available to prevent BC-breaks and renaming them would
 		 create a BC-break. -->
diff --git a/composer.json b/composer.json
index 1265c5bd5fb..cc188b0e052 100644
--- a/composer.json
+++ b/composer.json
@@ -93,7 +93,7 @@
 		],
 		"check-cs-thresholds": [
 			"@putenv YOASTCS_THRESHOLD_ERRORS=2545",
-			"@putenv YOASTCS_THRESHOLD_WARNINGS=267",
+			"@putenv YOASTCS_THRESHOLD_WARNINGS=253",
 			"Yoast\\WP\\SEO\\Composer\\Actions::check_cs_thresholds"
 		],
 		"check-cs": [