New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachment redirection to parent post doesn't work #1243

Closed
Firebird75 opened this Issue Jun 23, 2014 · 5 comments

Comments

Projects
None yet
2 participants
@Firebird75

Firebird75 commented Jun 23, 2014

Hello,

I am using SEO plugin 1.5.3.3 and WPML 3.1.6 and WP 3.9.1. The redirection of attachment page to parent post page doesn't work for non default language. It works fine for default language but not when the language isn't the default one.

@Firebird75 Firebird75 closed this Jun 23, 2014

@Firebird75

This comment has been minimized.

Firebird75 commented Jun 23, 2014

The issue is a bit "tricky". Basically, if there is no parent post, it won't redirect (which is expected even though some would suggest that it could redirect to home page).

Then, if you have set the media parameters for noindex and saved, then set the redirection. This one isn't redirected and has the noindex tag. Then if you save again the metas parameters (media configuration won't be available if redirection is active), this will remove the previous setting to noindex media and they will become indexable. So you'll end up with orphan attachment that are indexed and you can't prevent this through configuration.

@Firebird75 Firebird75 reopened this Jun 23, 2014

@jrfnl

This comment has been minimized.

Contributor

jrfnl commented Jun 24, 2014

I don't understand the issue. If a post (or attachment) has a redirection set, it's not added to the sitemap and when the actual post is called, it will redirect, so what's the problem ?

@Firebird75

This comment has been minimized.

Firebird75 commented Jun 25, 2014

The problem is for attachments without a parent post. They won't get redirected to anything but there is no possibility to add a noindex to them if the redirection parameter is set.

jrfnl added a commit to jrfnl/wordpress-seo that referenced this issue Jun 26, 2014

jrfnl added a commit to jrfnl/wordpress-seo that referenced this issue Jun 26, 2014

@jrfnl

This comment has been minimized.

Contributor

jrfnl commented Jun 26, 2014

@Firebird75 Now I understand! Ok, I get your point. I've send in PR #1256 to fix this. Do you agree that that will solve it ?

Closing this issue in favour of the pull request.

@jrfnl jrfnl closed this Jun 26, 2014

@jrfnl jrfnl added the admin label Jun 26, 2014

@Firebird75

This comment has been minimized.

Firebird75 commented Jun 26, 2014

Yes it will fix, thanks a lot!!!

jrfnl added a commit that referenced this issue Jun 26, 2014

Merge pull request #1256 from jrfnl/Issue-1243-attachments-redirect-n…
…o-parent

Fix issue #1243 - media attachments without parent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment