Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HH and MM fields in HowTo block do not allow 00 #12541

Open
dariaknl opened this issue Mar 28, 2019 · 3 comments

Comments

@dariaknl
Copy link
Contributor

@dariaknl dariaknl commented Mar 28, 2019

How can we reproduce this behavior?

  1. Install and activate Yoast SEO 10.0.1.
  2. Start adding HowTo block: you cannot add 00 to hours and minutes fields in Time needed, only 0, which feels counterintuitive.

Screenshot 2019-03-28 at 12 41 04

@emilyatmobtown

This comment has been minimized.

Copy link
Contributor

@emilyatmobtown emilyatmobtown commented Jul 8, 2019

I've written a patch for this that allows "0" or "00" in the DD, HH, and MM fields. However, it feels counterintuitive to only allow a leading zero for "0".

In other words, it would be more consistent to either:

  1. force all input to have a leading zero to match the DD/HH/MM placeholders or
  2. accept input with or without leading zeros for any valid integer.

Any feedback on this?

@Djennez

This comment has been minimized.

Copy link
Contributor

@Djennez Djennez commented Aug 8, 2019

@thijsdevalk can you provide your opinion on this from a usability point of view?

Personally I would go for the second option, as the default values display 2-digit content (HH:MM) I find it strange to not accept exactly that. Having said that, forcing a double zero to indicate zero is pointless as well.

@thijsdevalk

This comment has been minimized.

Copy link

@thijsdevalk thijsdevalk commented Aug 8, 2019

Option 2, definitely. It's very counterintuitive to have to fill out a 0 if the it takes a single digit amount of time. I can also imagine this impacting, for some themes, how it looks on the frontend, so we should leave decision on 1 or 2 digits with the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.