Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX improvements to snippet preview #13192

Open
hedgefield opened this issue Jul 1, 2019 · 4 comments

Comments

@hedgefield
Copy link
Contributor

commented Jul 1, 2019

Is your feature request related to a problem? Please describe.

The current toggle to switch between the mobile and desktop snippet preview is unclear. Based on the discussion about UX and a11y in this design issue, we have an approved product solution to build.

Describe the solution you'd like

snippet

cc @IreneStr

@IreneStr

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

The radio buttons are based on those from Material UI. You can take some inspiration from their repo: https://github.com/mui-org/material-ui/tree/3f56ea14dbb964578eebe4258b50b2a0426c8cfb

@IreneStr

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

@hedgefield During the scrum meeting, we decided to not collapse the edit fields by default, because that pushes the SEO analysis down to much.

@IreneStr IreneStr added the 3 label Jul 1, 2019
@thijsdevalk thijsdevalk added the blocked label Aug 23, 2019
@Yoast Yoast deleted a comment from uxkai Aug 23, 2019
@Yoast Yoast deleted a comment from hedgefield Aug 23, 2019
@luckickken

This comment has been minimized.

Copy link
Collaborator

commented Aug 23, 2019

@IreneStr, @thijsdevalk and I decided a while ago to replace the radio buttons for a toggle switch. But after some consideration, I decided that this use case isn't suited for a toggle switch after all. For now, we'll stick to using radio buttons.

@IreneStr IreneStr removed the blocked label Oct 14, 2019
@hwinne hwinne self-assigned this Oct 14, 2019
@hwinne

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2019

The radio buttons will not be styled like the material-ui components within this issue. After some consideration, for consistency's sake, the decision was made that a component should be created for all radio buttons, not only the ones in the scope of this issue. A separate issue will be created to redesign all radio buttons. In this issue default radio buttons will be used.

(CC @luckickken )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.