-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Options table uses optimisation #4389
Comments
Agreed. I think this slipped past since validator entries are actually options, not transients. |
I'm working with a site on the same WP and plugin versions (4.4.2, 3.1.2 respectively) that has more than 1800 cache_validator options. And I know of another site (unknown versions) with over 7700 cache_validator options. Will an update from v3.1.2 to v3.2.4/current resolve this? I'm working on testing this locally, but circumstances make it a bit of an undertaking, and am hoping for a quick definitive answer :) |
It's not fixed yet, but I am getting to it soon(ish)... I am down to like 30 unpatched sitemaps issues (hey, it was a looot more). |
Opened PR to kill autoload. Though I am pretty puzzled why would this be in the hundreds. Validator is saved once per type. I doubt that site got 7700 custom post types or something? What does keys for it look like? |
Hello @Rarst Some more info (www.frandroid.com, 30k published posts, 15M PVs/M): |
Thank you, now I see few numeric entries in my dev install, but I don't understand what they even stand for. Will look into it. |
I've asked around and the issue with creating multiple entries should have been fixed as part of ongoing work and should not happen anymore in current stable. Please let us know if you observe the count still growing. |
I updated but still see a lot of these cache validator entries. Are they safe to remove/clean up? |
@archon810 yes, they are safe to remove :) |
|
I think that the plugin ought to have code to automatically remove these, if they are no longer needed. I have apparently had over 10,000 of these slowing my site down for over a year since they became unnecessary. |
overhere the same problem evertime a overload |
Please move this data out of the wp_options table! |
At the beginning of each request, wordpress loads all wp_options lines that have autoload set to "yes".
What is the problem:
On my websites, it load ~550 lines : ~500 are wpseo_sitemap_XXX_cache_validator like options.
Do we really need all this lines, preloaded on every request ? We could all spare some milliseconds and database usage here.
Technical info
The text was updated successfully, but these errors were encountered: