Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification center: review the messages strings #5003

Open
afercia opened this issue Jun 22, 2016 · 5 comments
Open

Notification center: review the messages strings #5003

afercia opened this issue Jun 22, 2016 · 5 comments

Comments

@afercia
Copy link
Contributor

afercia commented Jun 22, 2016

A few messages in the notification center are actually built using two strings separated with a line break. Not sure if there's a specific reason for this, but probably it's something that should be avoided to give better context to translators and also for layout purposes, especially if the notification center is going to be fully responsive.

screen shot 2016-06-22 at 16 48 58

@afercia afercia changed the title Notification center: review the messages stirngs Notification center: review the messages strings Jun 22, 2016
@afercia
Copy link
Contributor Author

afercia commented Oct 13, 2016

@tacoverdo when you have a chance: should these strings be unified in a single string in your opinion?

@afercia
Copy link
Contributor Author

afercia commented Oct 3, 2018

This still happens on current trunk. Some notification text is made of 2 strings separated by a <br />:

screen shot 2018-10-03 at 09 26 59

@Djennez
Copy link
Member

Djennez commented Mar 1, 2019

This is currently still in Yoast 9.7 in the following functions:

  • page_comments_notice()
  • permalink_notice()

@afercia
Copy link
Contributor Author

afercia commented May 27, 2019

Looking back at old issues, I'd like to add a quick screenshot to better illustrate why forcing line breaks is not ideal for responsive design:

Screenshot 2019-05-27 at 11 36 31

@afercia
Copy link
Contributor Author

afercia commented Oct 31, 2019

Though minor, this is still a problem on current trunk.

Line breaks in a long text may look OK on large screens. But on small screens things are pretty different and they just look not OK:

Screenshot 2019-10-31 at 09 28 54

Screenshot 2019-10-31 at 09 29 21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants