Massive queries - WPSEO updating database a LOT! #627

Closed
OC2PS opened this Issue Jan 31, 2014 · 18 comments

Projects

None yet

4 participants

@OC2PS
OC2PS commented Jan 31, 2014

I have a WordPress install on a dedicated server with decent memory (upwards of 8GB)

Since upgrading to 3.8, I started getting mysql disconnects/timeouts, better known as
MySQL server has gone away

Debug Bar seems to indicate that WPSEO is initiating lots of massive queries that are killing my site.
UPDATE wp_options SET option_value...WHERE option_name= 'wpseo_titles'
require('wp-blog-header.php'), require_once('wp-includes/template-loader.php'), include('/themes/weaver-ii-pro/page.php'), weaverii_get_header, get_header, locate_template, load_template, require_once('/themes/weaver-ii-pro/header.php'), wp_title, apply_filters('wp_title'), call_user_func_array, WPSEO_Frontend->title, apply_filters('wpseo_title'), call_user_func_array, WPSEO_Frontend->title_test_helper, update_option
55.0ms

UPDATE wp_options SET option_value...WHERE option_name= 'wpseo_titles'
require('wp-blog-header.php'), require_once('wp-includes/template-loader.php'), include('/themes/weaver-ii-pro/page.php'), weaverii_get_header, get_header, locate_template, load_template, require_once('/themes/weaver-ii-pro/header.php'), wp_head, do_action('wp_head'), call_user_func_array, Facebook_Open_Graph_Protocol::add_og_protocol, apply_filters('fb_meta_tags'), call_user_func_array, WPSEO_OpenGraph->facebook_filter, WPSEO_OpenGraph->og_title, WPSEO_Frontend->title, apply_filters('wpseo_title'), call_user_func_array, WPSEO_Frontend->title_test_helper, update_option
56.4ms

UPDATE wp_options SET option_value...WHERE option_name= 'wpseo_titles'
require('wp-blog-header.php'), require_once('wp-includes/template-loader.php'), include('/themes/weaver-ii-pro/page.php'), weaverii_get_footer, get_footer, locate_template, load_template, require_once('/themes/weaver-ii-pro/footer.php'), wp_footer, do_action('wp_footer'), call_user_func_array, WPSEO_Frontend->flush_cache, WPSEO_Frontend->title, apply_filters('wpseo_title'), call_user_func_array, WPSEO_Frontend->title_test_helper, update_option
56.0ms

@OC2PS
OC2PS commented Feb 9, 2014

Can't be sure, but it seems that WPML and WordPress SEO combo is wreaking havoc.

See the bunch of FALSEs?

key: opt: array ( 'noindex-author' => '', 'disable-author' => '', 'noindex-archive' => '', 'noindex-category' => '', 'noindex-post_tag' => '', 'noindex-post_format' => '', 'noindex-subpages' => '', 'hide-rsdlink' => 'on', 'hide-feedlinks' => 'on', 'hide-wlwmanifest' => 'on', 'hide-shortlink' => 'on', 'title-home' => '%%sitename%% - %%sitedesc%%', 'title_test' => true, 'forcerewritetitle' => 'on', 'version' => '1.4.24', 'yoast_tracking' => true, 'hash' => '90e090d26bc0291c0aae7adfecd2a385', 'presstrends_popup' => 'done', 'presstrends' => 'off', 'theme_check' => array ( 'description' => true, ), 0 => false, 'plus-author' => '1', 'plus-publisher' => 'https://plus.google.com/u/0/103832696105380782000/posts', 'title-post' => '%%title%% | CsillámVilág | Csillámtetoválás, csillámfestés, arcfestés és henna', 'metadesc-post' => '', 'title-page' => '%%title%% | CsillámVilág | Csillámtetoválás, csillámfestés, arcfestés és henna', 'metadesc-page' => '', 'title-attachment' => '%%title%% | %%sitename%% | %%sitedesc%%', 'metadesc-attachment' => '', 'title-forum' => '', 'metadesc-forum' => '', 'title-topic' => '', 'metadesc-topic' => '', 'title-reply' => '', 'metadesc-reply' => '', 'title-ai1ec_event' => '%%title%% | Naptár | CsillámVilág | %%sitedesc%%', 'metadesc-ai1ec_event' => '', 'title-bgmp' => '%%title%% | Viszonteladó | %%sitename%% | %%sitedesc%%', 'metadesc-bgmp' => '', 'title-ptarchive-forum' => '', 'metadesc-ptarchive-forum' => '', 'title-ptarchive-topic' => '', 'metadesc-ptarchive-topic' => '', 'title-ptarchive-ai1ec_event' => '', 'metadesc-ptarchive-ai1ec_event' => '', 'title-category' => '', 'metadesc-category' => '', 'title-post_tag' => '', 'metadesc-post_tag' => '', 'title-post_format' => '', 'metadesc-post_format' => '', 'title-topic-tag' => '', 'metadesc-topic-tag' => '', 'title-events_categories' => '', 'metadesc-events_categories' => '', 'title-events_tags' => '', 'metadesc-events_tags' => '', 'title-bgmp-category' => '', 'metadesc-bgmp-category' => '', 'title-author' => '', 'metadesc-author' => '', 'title-archive' => '', 'metadesc-archive' => '', 'title-search' => '', 'title-404' => '', 'rssafter' => 'The post %%POSTLINK%% appeared first on %%BLOGLINK%%.', 1 => false, 'ignore_blog_public_warning' => '', 'ignore_page_comments' => '', 'ignore_permalink' => '', 'ms_defaults_set' => '', 'enablexmlsitemap' => 'on', 'xml_ping_yahoo' => 'on', 'xml_ping_ask' => 'on', 'post_types-forum-not_in_sitemap' => 'on', 'post_types-topic-not_in_sitemap' => 'on', 'post_types-reply-not_in_sitemap' => 'on', 'taxonomies-events_categories-not_in_sitemap' => 'on', 'taxonomies-events_tags-not_in_sitemap' => 'on', 'taxonomies-events_feeds-not_in_sitemap' => 'on', 'taxonomies-bgmp-category-not_in_sitemap' => 'on', 'taxonomies-topic-tag-not_in_sitemap' => 'on', 'post_types-attachment-not_in_sitemap' => 'on', 'opengraph' => 'on', 'fb_pageid' => NULL, 'fb_adminid' => NULL, 'fb_appid' => NULL, 'fbconnectkey' => '1fbcc7fa86da119322e954ae140e1b8e', 'tracking_popup' => 'done', 'ignore_tour' => 'ignore', 'redirectattachment' => 'on', 'cleanreplytocom' => 'on', 'force_transport' => 'default', 'cleanpermalink-extravars' => '', 'cleanslugs' => 'on', 2 => false, 3 => false, 4 => false, 5 => false, 6 => false, 7 => false, 8 => false, 9 => false, 10 => false, 11 => false, 12 => false, 13 => false, 14 => false, 15 => false, 16 => false, 17 => false, 18 => false, 19 => false, 20 => false, 21 => false, 22 => false, 23 => false, 24 => false, 25 => false, 26 => false, 27 => false, 28 => false, 29 => false, 30 => false, 31 => false, 32 => false, 33 => false, 34 => false, 35 => false, 36 => false, 37 => false, 38 => false, 39 => false, 40 => false, 41 => false, 42 => false, 43 => false, 44 => false, 45 => false, 46 => false, 47 => false, 48 => false, 49 => false, 50 => false, 51 => false, 52 => false, 53 => false, 54 => false, 55 => false, 56 => false, 57 => false, 58 => false, 59 => false, 60 => false, 61 => false, 62 => false, 63 => false, 64 => false, 65 => false, 66 => false, 67 => false, 68 => false, 69 => false, 70 => false, 71 => false, 72 => false, 73 => false, 74 => false, 75 => false, 76 => false, 77 => false, 78 => false, 79 => false, 80 => false, 81 => false, 82 => false, 83 => false, 84 => false, 85 => false, 86 => false, 87 => false, 88 => false, 89 => false, 90 => false, 91 => false, 92 => false, 93 => false, 94 => false, 95 => false, 96 => false, 97 => false, 98 => false, 99 => false, 100 => false, 101 => false, 102 => false, 103 => false, 104 => false, 105 => false, 106 => false, 107 => false, 108 => false, 109 => false, 110 => false, 111 => false, 112 => false, 113 => false, 114 => false, 115 => false, 116 => false, 117 => false, 118 => false, 119 => false, 120 => false, 121 => false, 122 => false, 123 => false, 124 => false, 125 => false, 126 => false, 127 => false, 128 => false, 129 => false, 130 => false, 131 => false, 132 => false, 133 => false, 134 => false, 135 => false, 136 => false, 137 => false, 138 => false, 139 => false, 140 => false, 141 => false, 142 => false, 143 => false, 144 => false, 145 => false, 146 => false, 147 => false, 148 => false, 149 => false, 150 => false, 151 => false, 152 => false, 153 => false, 154 => false, 155 => false, 156 => false, 157 => false, 158 => false, 159 => false, 160 => false, 161 => false, 162 => false, 163 => false, 164 => false, 165 => false, 166 => false, 167 => false, 168 => false, 169 => false, 170 => false, 171 => false, 172 => false, 173 => false, 174 => false, 175 => false, 176 => false, 177 => false, 178 => false, 179 => false, 180 => false, 181 => false, 182 => false, 183 => false, 184 => false, 185 => false, 186 => false, 187 => false, 188 => false, 189 => false, 190 => false, 191 => false, 192 => false, 193 => false, 194 => false, 195 => false, 196 => false, 197 => false, 198 => false, 199 => false, 200 => false, 201 => false, 202 => false, 203 => false, 204 => false, 205 => false, 206 => false, 207 => false, 208 => false, 209 => false, 210 => false, 211 => false, 212 => false, 213 => false, 214 => false, 215 => false, 216 => false, 217 => false, 218 => false, 219 => false, 220 => false, 221 => false, 222 => false, 223 => false, 224 => false, 225 => false, 226 => false, 227 => false, 228 => false, 229 => false, 230 => false, 231 => false, 232 => false, 233 => false, 234 => false, 235 => false, 236 => false, 237 => false, 238 => false, 239 => false, 240 => false, 241 => false, 242 => false, 243 => false, 244 => false, 245 => false, 246 => false, 247 => false, 248 => false, 'entries-per-page' => '', 'facebook_site' => '', 'og_frontpage_image' => '', 'og_frontpage_desc' => '', 'og_default_image' => '', 'twitter_site' => '', 'fb_admins' => array ( 100000658751540 => array ( 'name' => 'Krisztina Soós', 'link' => 'https://www.facebook.com/krisztina.soos.75', ), ), 249 => false, 250 => false, 251 => false, 252 => false, 253 => false, 254 => false, 255 => false, 256 => false, 257 => false, 258 => false, 259 => false, 260 => false, 261 => false, 262 => false, 263 => false, 264 => false, 265 => false, 266 => false, 267 => false, 268 => false, 269 => false, 270 => false, 271 => false, 272 => false, 273 => false, 274 => false, 275 => false, 276 => false, 277 => false, 278 => false, 279 => false, 280 => false, 281 => false, 282 => false, 283 => false, 284 => false, 285 => false, 286 => false, 287 => false, 288 => false, 289 => false, 290 => false, 291 => false, 292 => false, 293 => false, 294 => false, 295 => false, 296 => false, 297 => false, 298 => false, 299 => false, 300 => false, 301 => false, 302 => false, 303 => false, 304 => false, 305 => false, 306 => false, 307 => false, 308 => false, 309 => false, 310 => false, 311 => false, 312 => false, 313 => false, 314 => false, 315 => false, 316 => false, 317 => false, 318 => false, 319 => false, 320 => false, 321 => false, 322 => false, 323 => false, 324 => false, 325 => false, 326 => false, 327 => false, 328 => false, 329 => false, 330 => false, 331 => false, 332 => false, 333 => false, 334 => false, 335 => false, 336 => false, 337 => false, 338 => false, 339 => false, 340 => false, 341 => false, 342 => false, 343 => false, 344 => false, 345 => false, 346 => false, 347 => false, 348 => false, 349 => false, 350 => false, 351 => false, 352 => false, 353 => false, 354 => false, 355 => false, 356 => false, 357 => false, 358 => false, 359 => false, 360 => false, 361 => false, 362 => false, 363 => false, 364 => false, 365 => false, 366 => false, 367 => false, 368 => false, 369 => false, 370 => false, 371 => false, )

key: opt: array ( 'noindex-author' => '', 'disable-author' => '', 'noindex-archive' => '', 'noindex-category' => '', 'noindex-post_tag' => '', 'noindex-post_format' => '', 'noindex-subpages' => '', 'hide-rsdlink' => 'on', 'hide-feedlinks' => 'on', 'hide-wlwmanifest' => 'on', 'hide-shortlink' => 'on', 'title-home' => '%%sitename%% - %%sitedesc%%', 'title_test' => true, 'forcerewritetitle' => 'on', 'version' => '1.4.24', 'yoast_tracking' => true, 'hash' => '90e090d26bc0291c0aae7adfecd2a385', 'presstrends_popup' => 'done', 'presstrends' => 'off', 'theme_check' => array ( 'description' => true, ), 0 => false, 'plus-author' => '1', 'plus-publisher' => 'https://plus.google.com/u/0/103832696105380782000/posts', 'title-post' => '%%title%% | CsillámVilág | Csillámtetoválás, csillámfestés, arcfestés és henna', 'metadesc-post' => '', 'title-page' => '%%title%% | CsillámVilág | Csillámtetoválás, csillámfestés, arcfestés és henna', 'metadesc-page' => '', 'title-attachment' => '%%title%% | %%sitename%% | %%sitedesc%%', 'metadesc-attachment' => '', 'title-forum' => '', 'metadesc-forum' => '', 'title-topic' => '', 'metadesc-topic' => '', 'title-reply' => '', 'metadesc-reply' => '', 'title-ai1ec_event' => '%%title%% | Naptár | CsillámVilág | %%sitedesc%%', 'metadesc-ai1ec_event' => '', 'title-bgmp' => '%%title%% | Viszonteladó | %%sitename%% | %%sitedesc%%', 'metadesc-bgmp' => '', 'title-ptarchive-forum' => '', 'metadesc-ptarchive-forum' => '', 'title-ptarchive-topic' => '', 'metadesc-ptarchive-topic' => '', 'title-ptarchive-ai1ec_event' => '', 'metadesc-ptarchive-ai1ec_event' => '', 'title-category' => '', 'metadesc-category' => '', 'title-post_tag' => '', 'metadesc-post_tag' => '', 'title-post_format' => '', 'metadesc-post_format' => '', 'title-topic-tag' => '', 'metadesc-topic-tag' => '', 'title-events_categories' => '', 'metadesc-events_categories' => '', 'title-events_tags' => '', 'metadesc-events_tags' => '', 'title-bgmp-category' => '', 'metadesc-bgmp-category' => '', 'title-author' => '', 'metadesc-author' => '', 'title-archive' => '', 'metadesc-archive' => '', 'title-search' => '', 'title-404' => '', 'rssafter' => 'The post %%POSTLINK%% appeared first on %%BLOGLINK%%.', 1 => false, 'ignore_blog_public_warning' => '', 'ignore_page_comments' => '', 'ignore_permalink' => '', 'ms_defaults_set' => '', 'enablexmlsitemap' => 'on', 'xml_ping_yahoo' => 'on', 'xml_ping_ask' => 'on', 'post_types-forum-not_in_sitemap' => 'on', 'post_types-topic-not_in_sitemap' => 'on', 'post_types-reply-not_in_sitemap' => 'on', 'taxonomies-events_categories-not_in_sitemap' => 'on', 'taxonomies-events_tags-not_in_sitemap' => 'on', 'taxonomies-events_feeds-not_in_sitemap' => 'on', 'taxonomies-bgmp-category-not_in_sitemap' => 'on', 'taxonomies-topic-tag-not_in_sitemap' => 'on', 'post_types-attachment-not_in_sitemap' => 'on', 'opengraph' => 'on', 'fb_pageid' => NULL, 'fb_adminid' => NULL, 'fb_appid' => NULL, 'fbconnectkey' => '1fbcc7fa86da119322e954ae140e1b8e', 'tracking_popup' => 'done', 'ignore_tour' => 'ignore', 'redirectattachment' => 'on', 'cleanreplytocom' => 'on', 'force_transport' => 'default', 'cleanpermalink-extravars' => '', 'cleanslugs' => 'on', 2 => false, 3 => false, 4 => false, 5 => false, 6 => false, 7 => false, 8 => false, 9 => false, 10 => false, 11 => false, 12 => false, 13 => false, 14 => false, 15 => false, 16 => false, 17 => false, 18 => false, 19 => false, 20 => false, 21 => false, 22 => false, 23 => false, 24 => false, 25 => false, 26 => false, 27 => false, 28 => false, 29 => false, 30 => false, 31 => false, 32 => false, 33 => false, 34 => false, 35 => false, 36 => false, 37 => false, 38 => false, 39 => false, 40 => false, 41 => false, 42 => false, 43 => false, 44 => false, 45 => false, 46 => false, 47 => false, 48 => false, 49 => false, 50 => false, 51 => false, 52 => false, 53 => false, 54 => false, 55 => false, 56 => false, 57 => false, 58 => false, 59 => false, 60 => false, 61 => false, 62 => false, 63 => false, 64 => false, 65 => false, 66 => false, 67 => false, 68 => false, 69 => false, 70 => false, 71 => false, 72 => false, 73 => false, 74 => false, 75 => false, 76 => false, 77 => false, 78 => false, 79 => false, 80 => false, 81 => false, 82 => false, 83 => false, 84 => false, 85 => false, 86 => false, 87 => false, 88 => false, 89 => false, 90 => false, 91 => false, 92 => false, 93 => false, 94 => false, 95 => false, 96 => false, 97 => false, 98 => false, 99 => false, 100 => false, 101 => false, 102 => false, 103 => false, 104 => false, 105 => false, 106 => false, 107 => false, 108 => false, 109 => false, 110 => false, 111 => false, 112 => false, 113 => false, 114 => false, 115 => false, 116 => false, 117 => false, 118 => false, 119 => false, 120 => false, 121 => false, 122 => false, 123 => false, 124 => false, 125 => false, 126 => false, 127 => false, 128 => false, 129 => false, 130 => false, 131 => false, 132 => false, 133 => false, 134 => false, 135 => false, 136 => false, 137 => false, 138 => false, 139 => false, 140 => false, 141 => false, 142 => false, 143 => false, 144 => false, 145 => false, 146 => false, 147 => false, 148 => false, 149 => false, 150 => false, 151 => false, 152 => false, 153 => false, 154 => false, 155 => false, 156 => false, 157 => false, 158 => false, 159 => false, 160 => false, 161 => false, 162 => false, 163 => false, 164 => false, 165 => false, 166 => false, 167 => false, 168 => false, 169 => false, 170 => false, 171 => false, 172 => false, 173 => false, 174 => false, 175 => false, 176 => false, 177 => false, 178 => false, 179 => false, 180 => false, 181 => false, 182 => false, 183 => false, 184 => false, 185 => false, 186 => false, 187 => false, 188 => false, 189 => false, 190 => false, 191 => false, 192 => false, 193 => false, 194 => false, 195 => false, 196 => false, 197 => false, 198 => false, 199 => false, 200 => false, 201 => false, 202 => false, 203 => false, 204 => false, 205 => false, 206 => false, 207 => false, 208 => false, 209 => false, 210 => false, 211 => false, 212 => false, 213 => false, 214 => false, 215 => false, 216 => false, 217 => false, 218 => false, 219 => false, 220 => false, 221 => false, 222 => false, 223 => false, 224 => false, 225 => false, 226 => false, 227 => false, 228 => false, 229 => false, 230 => false, 231 => false, 232 => false, 233 => false, 234 => false, 235 => false, 236 => false, 237 => false, 238 => false, 239 => false, 240 => false, 241 => false, 242 => false, 243 => false, 244 => false, 245 => false, 246 => false, 247 => false, 248 => false, 'entries-per-page' => '', 'facebook_site' => '', 'og_frontpage_image' => '', 'og_frontpage_desc' => '', 'og_default_image' => '', 'twitter_site' => '', 'fb_admins' => array ( 100000658751540 => array ( 'name' => 'Krisztina Soós', 'link' => 'https://www.facebook.com/krisztina.soos.75', ), ), 249 => false, 250 => false, 251 => false, 252 => false, 253 => false, 254 => false, 255 => false, 256 => false, 257 => false, 258 => false, 259 => false, 260 => false, 261 => false, 262 => false, 263 => false, 264 => false, 265 => false, 266 => false, 267 => false, 268 => false, 269 => false, 270 => false, 271 => false, 272 => false, 273 => false, 274 => false, 275 => false, 276 => false, 277 => false, 278 => false, 279 => false, 280 => false, 281 => false, 282 => false, 283 => false, 284 => false, 285 => false, 286 => false, 287 => false, 288 => false, 289 => false, 290 => false, 291 => false, 292 => false, 293 => false, 294 => false, 295 => false, 296 => false, 297 => false, 298 => false, 299 => false, 300 => false, 301 => false, 302 => false, 303 => false, 304 => false, 305 => false, 306 => false, 307 => false, 308 => false, 309 => false, 310 => false, 311 => false, 312 => false, 313 => false, 314 => false, 315 => false, 316 => false, 317 => false, 318 => false, 319 => false, 320 => false, 321 => false, 322 => false, 323 => false, 324 => false, 325 => false, 326 => false, 327 => false, 328 => false, 329 => false, 330 => false, 331 => false, 332 => false, 333 => false, 334 => false, 335 => false, 336 => false, 337 => false, 338 => false, 339 => false, 340 => false, 341 => false, 342 => false, 343 => false, 344 => false, 345 => false, 346 => false, 347 => false, 348 => false, 349 => false, 350 => false, 351 => false, 352 => false, 353 => false, 354 => false, 355 => false, 356 => false, 357 => false, 358 => false, 359 => false, 360 => false, 361 => false, 362 => false, 363 => false, 364 => false, 365 => false, 366 => false, 367 => false, 368 => false, 369 => false, 370 => false, 371 => false, ) <hr>CsillámVilág | Csillámtetoválás, csillámfestés, arcfestés, testfestéshttp://csillamvilag.com/#ixzz2soWvPp2x
@jrfnl
Contributor
jrfnl commented Feb 9, 2014

Not sure what WPML has got to do with this, but the options as saved in the second comment will no longer happen/be possible in v1.5.

Looking at the tracebacks from the first comment. Seems the problem is that title_test_helper is being called from the wpseo_title filter every single time a call to a title is made. This is wrong and shouldn't happen. Needs debugging.

WPSEO_Frontend->title,
apply_filters('wpseo_title'),
call_user_func_array,
WPSEO_Frontend->title_test_helper
@jrfnl
Contributor
jrfnl commented Feb 9, 2014

I've looked at the v1.5 code to see if this issue could still happen and have changed some code to hopefully prevent further issues with the title_test_helper.

Still the extra keys are strange and something I have no idea of what could be causing it.

@jrfnl
Contributor
jrfnl commented Feb 9, 2014

@OC2PS Would you be willing to test v1.5 to see it this is now fixed ?

@OC2PS
OC2PS commented Feb 9, 2014

I figure issue is at WPML's icl_st_translate_admin_string. With WordPress SEO enabled, WPML gets this function called with name="" and keeps lenghtening the option_value array with "falses".

@OC2PS
OC2PS commented Feb 9, 2014

Sure, happy to test 1.5

@OC2PS
OC2PS commented Feb 9, 2014

I suppose it's important for WPML that all strings have name tags...else it goes berserk...

@OC2PS
OC2PS commented Feb 9, 2014

How do I grab 1.5? When will it be available?

@jrfnl
Contributor
jrfnl commented Feb 9, 2014
@OC2PS
OC2PS commented Feb 9, 2014

Thanks! Shall I just overwrite old plugin files with this release's files? Or does it make any changes to database too?

@barrykooij
Contributor

It does, allot of them. Be sure to backup your database, just in case.

@jrfnl
Contributor
jrfnl commented Feb 9, 2014

I figure issue is at WPML's icl_st_translate_admin_string. With WordPress SEO enabled, WPML gets this function called with name="" and keeps lenghtening the option_value array with "falses".

I suppose it's important for WPML that all strings have name tags...else it goes berserk...

That to me seems like a WPML issue and should be reported to them.
Though as I said before, the saving of all those falses will just not happen anymore in WPSEO 1.5. Not sure if that will break something in WPML, still they have been pre-informed/warned of quite extensive changes in WPSEO and asked to verify that things will still work.

@OC2PS
OC2PS commented Feb 9, 2014

@barrykooij What's the best way to upgrade then? I have downloaded https://github.com/Yoast/wordpress-seo/archive/release/1.5.zip (wordpress-seo-release-1.5.zip)

@jrfnl Yeah, I think they do need to fix it. At the same time, I think WordPress SEO needs to have name tags for all strings so that strings can be translated as and when needed...what do you think?

@OC2PS
OC2PS commented Feb 10, 2014

@barrykooij ?
I ask because the zip files of older version from wordpress.org and the 1.5 zip from github have different names and I am wondering if WordPress will be able to do an automatic upgrade if I try to upload the zip file....via the plugin install function...

@jrfnl
Contributor
jrfnl commented Feb 10, 2014

@OC2PS Uploading the zip won't work for the upgrade. You will have to unzip the files and upload them via FTP. As Barry said, do make a backup of the database (and files if you like) before testing and also, please don't test on a live site.

@OC2PS
OC2PS commented Feb 10, 2014

Thanks @jrfnl Will uploading the files via FTP suffice? I mean, if the upgrade is supposed to make some db changes compared to previous versions (as @barrykooij seems to have indicated), wouldn't just uploading the files lead to a mess?

@jrfnl
Contributor
jrfnl commented Feb 10, 2014

@OC2PS Yes, uploading via FTP will be fine. The upgrade will be run automatically.
Or in more technical terms: on each page load WPSEO does a compare between the saved version nr and the file version nr. If they don't match (saved <file), the upgrade will be run.

@jdevalk
Member
jdevalk commented Aug 8, 2014

This has probably been fixed in recent releases, please do re-open if you're still experiencing problems.

@jdevalk jdevalk closed this Aug 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment