Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Latest update breaks Soliloquy #733

Closed
osalcedo opened this Issue Mar 11, 2014 · 6 comments

Comments

Projects
None yet
3 participants

I updated the plugin to the latest version and the image query in Soliloquy disappeared.
I verified by disabling Yoast and reenabling it.

We're having exactly the same issue.

Also, when Yoast's admin pages are open, the menu-items above it and below the dashboard link (marked here with an * ) aren't clickable.

yoast-soliloquy

We're using Wordpress 3.8.1 Wordpress SEO by Yoast, and Soliloquy with it's featured posts plugin.

@jrfnl jrfnl added a commit to jrfnl/wordpress-seo that referenced this issue Mar 12, 2014

@jrfnl jrfnl Fix WP Admin menu items no longer clickable when on WPSEO pages as re…
…ported in [issue #733](Yoast#733) and [#738](Yoast#738)
856821d
Contributor

jrfnl commented Mar 12, 2014

@mattisherwood You are mixing two issues which is not very helpful. Anyways, no news on the Soliloquy front, but the menu clickability issue should be fixed by pull request #745.

Contributor

jrfnl commented Mar 12, 2014

@osalcedo Please provide more information. I'm not familiar with Soliloquy. Do you get any PHP errors and if so, what are they ?

Ah yes, sorry for mixing the issues, I'm guessing they're not linked. Thanks for addressing it in the right place!

Whilst using Chrome Inspector to check out the Soliloquy slider's admin pages that I pictured above, I get the following...

Type Content
Error: Uncaught TypeError: Cannot call method 'keyup' of undefined wp-seo-metabox.min.js?ver=1.5.2:1
Warning event.returnValue is deprecated. Please use the standard event.preventDefault() instead.

Does that help?

Contributor

jrfnl commented Mar 12, 2014

Uncaught TypeError: Cannot call method 'keyup' of undefined wp-seo-metabox.min.js?ver=1.5.2:1

That helps. I think I've figured out what's causing the issue. Pull request #758 will probably fix this.

@jrfnl jrfnl added bug Metabox labels Mar 12, 2014

Contributor

jrfnl commented Mar 12, 2014

Closing as pull request is now merged in master.

@jrfnl jrfnl closed this Mar 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment