Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Double message when adding Facebook admin #743

Closed
steverep opened this Issue Mar 11, 2014 · 4 comments

Comments

Projects
None yet
3 participants

I had issues with 1.4.25 where my server threw an error when I tried to add a Facebook admin. After updating to 1.5.0, it now seems to work but I get multiple messages saying "Successfully added...". This happens even after hitting the "Clear all Facebook data" button.

Contributor

jrfnl commented Mar 12, 2014

Could you please add a screenshot to illustrate ?

Owner

jdevalk commented Mar 12, 2014

I've seen it too, not able to replicate now, but it's weird when I look at the code :)

I'd rather not show a screenshot just for privacy reasons, but it's really pretty simple - I just see the same message twice at the top of screen. So if this is only happening for me, then putting my logic gloves on tells me it's got something to do with a very special set of circumstances. My random 2 cents having never looked at the code:

(1) Something in the plugin wasn't cleared from the server errors I was getting in 1.4. Can I do this manually somehow? (w/o resetting everything preferably)
(2) My new facebook page not having Insights enabled yet playing a role
(3) My site forcing SSL admin but not the rest of the site playing a role

I see nothing in the browser console that offers any clue.

@jrfnl jrfnl added a commit to jrfnl/wordpress-seo that referenced this issue Mar 15, 2014

@jrfnl jrfnl Fixes issue #743 - duplicate feedback messages on social page 8806be3
Contributor

jrfnl commented Mar 15, 2014

I've found & fixed it - see PR #819.

@jrfnl jrfnl closed this Mar 15, 2014

@jrfnl jrfnl added the Social label Mar 15, 2014

@jdevalk jdevalk added a commit that referenced this issue Mar 15, 2014

@jdevalk jdevalk Merge pull request #819 from jrfnl/Issue-743-social-duplicate-feedback
Fixes issue #743 - duplicate feedback messages on social page
160fbe7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment