Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with WPMU Membership 2 Plugin #8218

Closed
theRealRizeo opened this issue Nov 6, 2017 · 5 comments

Comments

Projects
None yet
5 participants
@theRealRizeo
Copy link

commented Nov 6, 2017

  • I've read and understood the contribution guidelines.
  • I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened.

When the custom post type or an invoice is being saved after a user subscribes in the front-end, the custom post type is not persisted to the database causing the plugin not to work as expected.

Please describe what you expected to happen and why.

Invoice custom post type saved and normal process of completing registration continues

How can we reproduce this behavior?

  1. Install Membership 2
  2. Set up a membership. No need to set up any payment gateway
  3. Make sure Yoast is active and try to sign up for the membership

Technical info

  • WordPress version: 4.8.3
  • Yoast SEO version: 5.7.1
  • Relevant plugins in case of a bug: Membership 2
@benvaassen

This comment has been minimized.

Copy link
Member

commented Nov 7, 2017

Thank you for reporting this bug.
It's marked as backlog, so it appears in the to do-list of our development team. You can also contact the developer of the plugin and they can also create a PR if the issue can be fixed in our plugin.

I also get the following PHP error when I try to sign up for the membership:

screencapture-local-wordpress-dev-memberships-1510057446897

@theRealRizeo

This comment has been minimized.

Copy link
Author

commented Nov 7, 2017

Hello @benvaassen,

Thank you for the response. I am currently working on the plugin at WPMU Dev. I will try and see if I can add a workaround for this. The error in the logs you shared seem to be a php config and can be adjusted by increasing the value of xdebug.max_nesting_level .

@theRealRizeo

This comment has been minimized.

Copy link
Author

commented Nov 15, 2017

Hey there @benvaassen,

Hope you are well today. I've found that setting the invoice custom post type to private removes this error. I'm still running a few tests but it seems to be working

@MisterDuval

This comment has been minimized.

Copy link

commented Nov 15, 2017

I confirm, in membership\app\model\class-ms-model-invoice.php, line 327 put public to false 👍
'public' => false,

@Djennez

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2019

As this issue is more than 2 years old and has not received any endorsements in the meantime, I'll be closing it. If this issue is still relevant today, please open a new issue thread with new details.

@Djennez Djennez closed this Feb 1, 2019

@omarreiss omarreiss removed backlog bug labels Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.