Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

No Sorting & Filtering #838

Closed
gmuehl opened this Issue · 21 comments

5 participants

@gmuehl

For some strange reasons Sorting Articles with the new Columns (Focus Keyword) or Filtering (Articles without Focus Keyword) results in NO Articles. Though, it should report at last 100 Articles in this Blog.
wpseo

@jrfnl
Collaborator

I cannot reproduce the sorting issue, however I have tested & can confirm the filtering issue. Will look into that.

@jrfnl
Collaborator

Interesting, looks like the actual filtering was never implemented. Is that correct @jdevalk ? or am I looking in the wrong place or something ?

@jrfnl
Collaborator

Actually just tested in v1.4.25, it did used to work... will investigate further.

@jdevalk
Owner

It's ages ago that I wrote that but yes, it did use to work :)

@jrfnl
Collaborator

Correction, I tested in v1.4.19 and it worked fine there, but I think it will have started failing as soon as we stopped saving the default meta values. Will need to get my head around how to change the query to take into account non-existance of the meta values.

@jrfnl
Collaborator

@gmuehl - would you mind checking whether it still works when you select the "SEO: Post Noindexed" choice ? It believe it should. Helps me to focus on only what needs changing.

@jrfnl
Collaborator

@jdevalk Do you know of any way I can combine the use of AND and OR relations in query adjustments without creating a custom query ? Cause that's basically what we need.

Something along the lines of:
( no-index != 1 OR NOT EXISTS ) AND linkdex value check

@jdevalk
Owner

What's the entire code? Can't really remember how it works, I think you can do a meta query that does all of that...

@jrfnl
Collaborator

@jdevalk https://github.com/Yoast/wordpress-seo/blob/master/admin/class-metabox.php#L847 - line 883-900 for the actual query setting which I believe is the cause of the issue.

The problem with using meta query (which it does under the hood using native WP) is that you can only have either AND or OR, not combine them using the standard interface.

@gmuehl

@jrfnl "SEO: Post Noindexed" does not show any results too

@jrfnl
Collaborator

@gmuehl Thanks for checking. Just to make sure: you do have posts which are on a per-post basis set to no-index ?

@jrfnl
Collaborator

@gmuehl Ah, ok, that means that the "SEO: Post Noindexed" could be working correctly. Would you mind (temporarily) setting one post to no-index via Posts -> Edit -> SEO Metabox -> Advanced tab->Indexing dropdown -> Publish/Save as draft and then try to filter with "SEO: Post Noindexed" again to see if that one post shows up ?

@jrfnl jrfnl referenced this issue from a commit in jrfnl/wordpress-seo
@jrfnl jrfnl Fix post filtering via dropdown - issue #838 cd2bb55
@jrfnl
Collaborator

I believe I've fixed this now in pull request #841. Testing of the fix is welcome ;-)

@jrfnl
Collaborator

As the fix is now merged to master, I'm closing the issue. The fix will be included in the next release.

@jrfnl jrfnl closed this
@gmuehl

@jrfnl Actually it does not work in 1.08 Premium ;) Sorting works agains, but limits the Articles from 200+ to 60. The Filters show a strange behaviour: The Filter "SEO: Good" Works fine, but NONE of the Other filters.

@jrfnl
Collaborator

@gmuehl I'm not sure whether the change has been merged into premium yet. @barrykooij ?

@barrykooij

Premium 1.0.8 uses WPSEO core 1.5.2.5.

@jrfnl
Collaborator

Re-opening as the fix was included in WPSEO Core 1.5.2.3.

@gmuehl Just checking: you do have posts/pages with other scores ?

I need more input as after the fix, I can no longer reproduce the behaviour.

@jrfnl jrfnl reopened this
@gmuehl

@jrfnl Some with "SEO: OK", but the filter returns an empty list. The Rest has no Focus Keyword (empty list too)

@gmuehl

Push! ;) 1.1.2 Premium, still no luck ;)

@andizer andizer was assigned by jdevalk
@jdevalk jdevalk closed this in 8bd04a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.