Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove x-redirect-by headers when WordPress 5.0 will be released #9993

Open
andizer opened this Issue Jun 11, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@andizer
Copy link
Contributor

andizer commented Jun 11, 2018

In #9887 we've added header('x-redirect-by: Yoast SEO'); for each redirect that has been done, like this one for example.

In WordPress 5.0 an optional argument for setting the x-redirect-by header is going to be introduced. WordPress will always set this header. If no argument is given it will set WordPress as x-redirect-by. Thus our x-redirect-by header will be overwritten in WordPress 5.0.

To prevent faulty situations we have to remove occurrences of x-redirect-by headers we have set in #9887.

@IreneStr

This comment has been minimized.

Copy link
Contributor

IreneStr commented Oct 23, 2018

We need to check if WordPress will introduce this in 5.0 or 5.1

@andizer

This comment has been minimized.

Copy link
Contributor Author

andizer commented Oct 23, 2018

I think it will be in 5.1, because on the WordPress trac I see this on trunk (5.1 release):
https://core.trac.wordpress.org/browser/trunk/src/wp-includes/pluggable.php#L1205
and on the 5.0 release branch it is:
https://core.trac.wordpress.org/browser/branches/5.0/src/wp-includes/pluggable.php#L1188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.