Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Black Friday 2019 banner #13736

Merged
merged 4 commits into from Oct 28, 2019

Conversation

@igorschoester
Copy link
Member

igorschoester commented Oct 28, 2019

Summary

This PR can be summarized in the following changelog entry:

  • Implements the Black Friday 2019 banner.

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

  • Check the Yoast dashboard for the banner.
  • Ensure you can dismiss the banner.
  • Then go to the dashboard again (do not use refresh to get rid of the dismiss variable in the URL). You should no longer see the banenr.
  • The dismissed database setting can be found in the wp_options table > wpseo option > bf_banner_2019_dismissed. You can manually reset this to 0 to get it back after dismissing.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

jdevalk and others added 4 commits Oct 25, 2019
- Output escaping of the URL
- Add z-index to fix the mouse hover issue of the X button
- Use the shortlinker for the usual extra system data
- Clean some PHPCS
@igorschoester

This comment has been minimized.

Copy link
Member Author

igorschoester commented Oct 28, 2019

Acceptance

@igorschoester igorschoester merged commit 7a3c65c into release/12.4 Oct 28, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@igorschoester igorschoester deleted the banner-bf branch Oct 28, 2019
@igorschoester igorschoester mentioned this pull request Oct 28, 2019
0 of 4 tasks complete
@indextwo

This comment has been minimized.

Copy link

indextwo commented Nov 28, 2019

This banner ad appears on every. single. page. of wp-admin. It can't be dismissed by the close cross unless you come at it VERY QUICKLY from the left-hand side. Approach it any other way and that cross is unclickable. In some cases, the banner obscures parts of the admin on some settings pages because - again - it's on every. single. page. Tested in Firefox 70, Chrome 78 & Opera 65.

Check your Twitter feed to see just how well this went down and maybe never do this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.