Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After some issues arose due to refactoring of the css, it was decided that the select2 implementation in the
SEMrushCountrySelector
component should be replaced with a react-select component from the monorepo (see javascript#851 for the adjustments made in the monorepo).IMPORTANT: the styling of the
SEMrushCountrySelector
component is not completely correct yet (i.e., the placement of the button next to the Select, it is currently still below the Select). An issue has already been added to the board of Team Frontend.Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
This PR can be tested by following these steps:
P3-144-adjust-multiselect
on wordpress-seo and the monorepoyarn link-monorepo
and build freecountryCode
value in the store is updated when you change the countrySingleSelect
component so it's not due to our PR (if you open theAdvanced
accordion item below, which uses the ReactSelect as well, you'll see the same warning):yarn test
to see that all the tests are passing (currently there are twoconsole.error
calls in another test that passes anyway, so ignore them)UI changes
Documentation
Quality assurance
Fixes [P3-144]