Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS/QA: silence a few deprecations #19128

Merged
merged 1 commit into from
Nov 6, 2022

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Nov 6, 2022

Context

  • Reduce noise from PHP 8.1 deprecations

Summary

This PR can be summarized in the following changelog entry:

  • Reduces noise from PHP 8.1 deprecations.

Relevant technical choices:

The deprecation of the FILTER_SANITIZE_STRING constant will be addressed at a later point, but is causing undue confusion for users, so for now, we'll be silencing the deprecation notices.

Includes updating a few test expectations to no longer expect the deprecation notice.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Fixes: #17991

@jrfnl jrfnl added yoast cs/qa changelog: other Needs to be included in the 'Other' category in the changelog labels Nov 6, 2022
@jrfnl jrfnl added this to the 19.12 milestone Nov 6, 2022
The deprecation of the `FILTER_SANITIZE_STRING` constant will be addressed at a later point, but is causing undue confusion for users, so for now, we'll be silencing the deprecation notices.

Includes updating a few test expectations to no longer expect the deprecation notice.
@jrfnl jrfnl force-pushed the JRF/php-8.1/silence-filter-deprecation-notices branch from 8a5c20d to 6a605e7 Compare November 6, 2022 18:43
@jrfnl jrfnl merged commit 0aaf94d into trunk Nov 6, 2022
@jrfnl jrfnl deleted the JRF/php-8.1/silence-filter-deprecation-notices branch November 6, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: other Needs to be included in the 'Other' category in the changelog yoast cs/qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constant FILTER_SANITIZE_STRING is deprecated
1 participant