Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dupp 900 introduction modal dialog accessibility #19650

Merged
merged 2 commits into from Jan 17, 2023

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented Jan 17, 2023

Context

Summary

This PR can be summarized in the following changelog entry:

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Block/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unit tests to verify the code works as intended
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label and noted the work hours.

Fixes Fix Introduction modal dialog a11y.

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jan 17, 2023
@vraja-pro vraja-pro added this to the 20.0 milestone Jan 17, 2023
@vraja-pro vraja-pro requested a review from a team as a code owner January 17, 2023 14:53
@vraja-pro
Copy link
Contributor Author

Related to different issue that was CR & ACC ✅

@vraja-pro vraja-pro merged commit 0a4653b into trunk Jan 17, 2023
@vraja-pro vraja-pro deleted the DUPP-900-introduction-modal-dialog-accessibility branch January 17, 2023 15:04
@vraja-pro vraja-pro restored the DUPP-900-introduction-modal-dialog-accessibility branch January 17, 2023 15:06
@vraja-pro vraja-pro deleted the DUPP-900-introduction-modal-dialog-accessibility branch January 17, 2023 15:13
@vraja-pro vraja-pro restored the DUPP-900-introduction-modal-dialog-accessibility branch January 17, 2023 15:13
@vraja-pro vraja-pro deleted the DUPP-900-introduction-modal-dialog-accessibility branch January 17, 2023 15:19
@vraja-pro vraja-pro modified the milestones: 20.0, 20.1 Jan 17, 2023
@d-claassen d-claassen added changelog: reverted Needs to be excluded from all categories in the changelog, should be used for reverted PR and removed changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: reverted Needs to be excluded from all categories in the changelog, should be used for reverted PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants