Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds filter for inclusion of RSS footer embed #1990

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@hlashbrooke
Copy link
Contributor

commented Feb 16, 2015

Fixes #1989

Hugh Lashbrooke

pluginmirror-worker pushed a commit to wp-plugins/seriously-simple-podcasting that referenced this pull request Feb 16, 2015

hlashbrooke
Seriously Simple Podcasting v1.8.7
= 1.8.7 =
* 2015-02-16
- Removing getID3 class and switching to WordPress' built-in functions for retrieving ID3 data instead
- Improving retrieval of audio track length and file size
- Adding sanity checks when fetching podcast post types to ensure no errors are returned
- Adding global function for retrieving podcast post types to standardise and sanitise data
- Adding plugin generator tag to site header to indicate usage and current version
- Adding filter to hide WordPress SEO RSS footer embed on podcast feed if my patch is accepted: Yoast/wordpress-seo#1990

git-svn-id: https://plugins.svn.wordpress.org/seriously-simple-podcasting/trunk@1091205 b8457f37-d9ea-0310-8a92-e5e31aec5664
@jdevalk

This comment has been minimized.

Copy link

commented on frontend/class-frontend.php in e5809ce Feb 23, 2015

Makes more sense to me to just pass true, and not remove the is_feed() check, in which case you needn't make it a variable either and you could just merge this line with the line below.

This comment has been minimized.

Copy link
Owner

replied Feb 23, 2015

So then write it like this?

if( apply_filters( 'wpseo_include_rss_footer', is_feed() ) ) {
    ...
}

That works for me - I just did it this way to make it a bit more readable, but it doesn't make too much difference in the end. Happy to rework the patch if you're happy with that?

@hlashbrooke

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2015

Closing this to create new PR with updated patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.