Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add typescript support to bottender dev #654

Merged
merged 1 commit into from Feb 20, 2020

Conversation

jigsawye
Copy link
Contributor

When the tsconfig.json is in the project root, bottender dev will auto execute tsc to compile *.ts file before the server start.

@codecov-io
Copy link

codecov-io commented Feb 13, 2020

Codecov Report

Merging #654 into release/1.3 will decrease coverage by 0.3%.
The diff coverage is 8.69%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.3     #654      +/-   ##
===============================================
- Coverage        81.06%   80.75%   -0.31%     
===============================================
  Files              101      102       +1     
  Lines             4335     4354      +19     
  Branches          1078     1083       +5     
===============================================
+ Hits              3514     3516       +2     
- Misses             776      793      +17     
  Partials            45       45
Impacted Files Coverage Δ
...s/create-bottender-app/src/utils/generateConfig.ts 0% <0%> (ø) ⬆️
...create-bottender-app/src/utils/generateAppEntry.ts 0% <0%> (ø)
packages/create-bottender-app/src/index.ts 0% <0%> (ø) ⬆️
packages/bottender/src/cli/providers/sh/dev.ts 28.57% <33.33%> (+2.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 956540c...bceafad. Read the comment docs.

@chentsulin chentsulin changed the base branch from master to release/1.3 February 13, 2020 09:26
Copy link
Collaborator

@chentsulin chentsulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chentsulin chentsulin merged commit f573a0b into release/1.3 Feb 20, 2020
@chentsulin chentsulin deleted the feat/typescrip-bottender-dev branch February 20, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants