Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added docker and docker-compose files, see Readme.md to get details #1

Merged
merged 1 commit into from Mar 17, 2020

Conversation

@thekiba
Copy link
Contributor

thekiba commented Mar 17, 2020

No description provided.


You have to create an user by after rabbitmq started firstly:
```bash
docker-compose -f YogurtTheBot.ComposeFiles/docker-compose.yml exec rabbitmq rabbitmqctl add_user user user

This comment has been minimized.

Copy link
@YogurtTheHorse

YogurtTheHorse Mar 17, 2020

Owner

Maybe move it to Dockerfile?

@@ -7,12 +7,14 @@
}
},
"MongoSettings": {
"Database": "sb",
"ConnectionString": "mongodb://localhost:27017",
"Database": "root",

This comment has been minimized.

Copy link
@YogurtTheHorse

YogurtTheHorse Mar 17, 2020

Owner

I believe this should be in separate config. appsettings.Dockerfile.json or something like that, so this won't broke rgular development

@YogurtTheHorse

This comment has been minimized.

Copy link
Owner

YogurtTheHorse commented Mar 17, 2020

And maybe extract doker configuation. If you don't know how to deal with dotnet and configuration you can merge to feature/docker, so i'll finish everything up

@thekiba thekiba changed the base branch from master to feaure/docker Mar 17, 2020
@thekiba thekiba marked this pull request as ready for review Mar 17, 2020
@YogurtTheHorse YogurtTheHorse merged commit fbf633b into YogurtTheHorse:feaure/docker Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.