New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paths and defines for reagents, gasses, reactants and materials. #786

Merged
merged 8 commits into from Jun 6, 2018

Conversation

Projects
None yet
1 participant
@MistakeNot4892
Collaborator

MistakeNot4892 commented Apr 28, 2018

  • Converts material system to use paths instead of IDs. Replaces naked identifiers with defines.
  • Converts gas and fusion reaction systems to use defines instead of bare strings.
  • Converts reagent system to use paths instead of IDs, removes pointless ID and name fields from reactions, removes pointless ID field from reagents. Replaces naked identifiers with defines.

@MistakeNot4892 MistakeNot4892 force-pushed the MistakeNot4892:materials branch 3 times, most recently from 7284a59 to 55ae399 Apr 28, 2018

@MistakeNot4892 MistakeNot4892 changed the title from [DNM] Converts materials to paths. to Death to inter-PR compatibility. Apr 29, 2018

@MistakeNot4892 MistakeNot4892 force-pushed the MistakeNot4892:materials branch 4 times, most recently from 5105cac to d5f1bb8 Apr 29, 2018

@MistakeNot4892 MistakeNot4892 changed the title from Death to inter-PR compatibility. to Paths and defines for reagents, gasses, reactants and materials. Apr 29, 2018

@MistakeNot4892 MistakeNot4892 force-pushed the MistakeNot4892:materials branch from d5f1bb8 to 769a3d9 Apr 29, 2018

@MistakeNot4892 MistakeNot4892 reopened this Jun 5, 2018

@MistakeNot4892 MistakeNot4892 force-pushed the MistakeNot4892:materials branch 2 times, most recently from 465a6fb to 32493a7 Jun 5, 2018

@MistakeNot4892 MistakeNot4892 merged commit 2c29c51 into Yonaguni:master Jun 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment