New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vast swathes of icon and path fixes following major removals. #818

Merged
merged 13 commits into from Feb 4, 2019

Conversation

Projects
None yet
3 participants
@MistakeNot4892
Copy link
Collaborator

MistakeNot4892 commented Feb 1, 2019

TODO:

  • Convert base icon checks into a unit test.
  • Convert debug verb into a 'list unused icon states' verb.
  • Remove unused icon states.

@MistakeNot4892 MistakeNot4892 force-pushed the MistakeNot4892:clothes branch 7 times, most recently from 2df470c to 254ffdd Feb 1, 2019

@MistakeNot4892

This comment has been minimized.

Copy link
Collaborator Author

MistakeNot4892 commented Feb 1, 2019

Will do the icon cull in another PR.

@EmperorJon
Copy link
Collaborator

EmperorJon left a comment

I can't see any issues with my limited understanding. Although a lot of it isn't directly an "icon fix" I can see why we needn't be too picky at this stage about PRs which just fix/remove junk found in the process of, well, fixing and removing other junk.

@MistakeNot4892 MistakeNot4892 changed the title Vast swathes of icon fixes. Vast swathes of icon and path fixes following major removals. Feb 2, 2019

@MistakeNot4892 MistakeNot4892 force-pushed the MistakeNot4892:clothes branch from 514c61d to fa223b3 Feb 2, 2019

@EmperorJon

This comment has been minimized.

Copy link
Collaborator

EmperorJon commented Feb 2, 2019

Changes fix atmospherics being completely broken. (Still approved) 👍

@MistakeNot4892 MistakeNot4892 force-pushed the MistakeNot4892:clothes branch from fa223b3 to e9853f6 Feb 2, 2019

Show resolved Hide resolved code/modules/clothing/ears/earrings.dm Outdated
Show resolved Hide resolved code/modules/clothing/ears/earrings.dm Outdated

@MistakeNot4892 MistakeNot4892 force-pushed the MistakeNot4892:clothes branch 2 times, most recently from d081c13 to 29ba734 Feb 2, 2019

@MistakeNot4892 MistakeNot4892 force-pushed the MistakeNot4892:clothes branch from 29ba734 to f353799 Feb 2, 2019

@MistakeNot4892 MistakeNot4892 reopened this Feb 2, 2019

@MistakeNot4892 MistakeNot4892 force-pushed the MistakeNot4892:clothes branch 2 times, most recently from b182d3f to 989c094 Feb 3, 2019

@MistakeNot4892 MistakeNot4892 force-pushed the MistakeNot4892:clothes branch from 989c094 to baba76b Feb 4, 2019

@EmperorJon EmperorJon merged commit e6fdd2f into Yonaguni:cassini Feb 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment