This repository has been archived by the owner on Mar 16, 2023. It is now read-only.
handle correctly nested loops (fixes #178) #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,7 +58,7 @@ class LoopKeywords < Base | |||
| # @param [RubyLint::AST::Node] node | |||
| # | |||
| def verify_keyword(keyword, node) | |||
| if current_scope.type != :block and !@allow_keyword | |||
| if current_scope.type != :block && [0, nil].include?(@allow_keyword) | |||
There was a problem hiding this comment.
Why is there a nil check here? I'd rather have @allow_keyword always set to a Fixnum so this can just be and @allow_keyword == 0. Also please keep the and instead of &&.
There was a problem hiding this comment.
I have fixed that, renaming the attribute to loop_nesting, in mvidner@d38dc7d (branch https://github.com/mvidner/ruby-lint/tree/fix_nested_loops).
There was a problem hiding this comment.
@mvidner Please submit that to the same PR (or a new PR containing all the changes), I don't want to pick commits from random places.
|
Closing in favour of #185 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.