This repository has been archived by the owner. It is now read-only.

Absolute constant lookup (::Foo) #188

Merged
merged 8 commits into from Jun 28, 2016

Conversation

Projects
None yet
2 participants
@mvidner
Copy link
Contributor

mvidner commented Jun 27, 2016

This is a fix for #180.

It is built upon #184, so please see that one first.

@YorickPeterse

This comment has been minimized.

Copy link
Owner

YorickPeterse commented Jun 27, 2016

#184 is merged, could you rebase this PR based on the current master branch?

@mvidner mvidner force-pushed the mvidner:absolute-constant-lookup branch from bc1c0bb to 5b32d5f Jun 27, 2016

@mvidner

This comment has been minimized.

Copy link
Contributor

mvidner commented Jun 27, 2016

Rebased

#
# @return [RubyLint::AST::Node]
# @return [Array(Symbol,String)]

This comment has been minimized.

@YorickPeterse

YorickPeterse Jun 27, 2016

Owner

These changes don't seem to be related to this PR. If this method is not used anymore a separate PR should just remove it.

@@ -677,6 +683,12 @@ def inspect
return %Q(#<#{self.class}:0x#{address} #{attributes.join(' ')}>)
end

def top_scope
return self if type == :root
scope = parents.last # the enclosing scope?

This comment has been minimized.

@YorickPeterse

YorickPeterse Jun 27, 2016

Owner

What's the reason for this comment? Right now it doesn't really convey any useful information since it's a question.

This comment has been minimized.

@mvidner

mvidner Jun 28, 2016

Contributor

You're right. I was unsure about that. Now I have added more tests.

@YorickPeterse

This comment has been minimized.

Copy link
Owner

YorickPeterse commented Jun 27, 2016

@mvidner For future PRs please submit yardoc changes as a separate PR as this makes changes easier to review.

@mvidner mvidner referenced this pull request Jun 28, 2016

Merged

Yardoc improvements #189

@mvidner mvidner force-pushed the mvidner:absolute-constant-lookup branch from 5b32d5f to 19c2ec5 Jun 28, 2016

Remove RubyLint::ConstantPath#root_node
It is no longer used since 971a7da
@mvidner

This comment has been minimized.

Copy link
Contributor

mvidner commented Jun 28, 2016

Thank you, I've updated this to separate the yardoc, and add more tests.

@YorickPeterse YorickPeterse merged commit 9a349f7 into YorickPeterse:master Jun 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mvidner mvidner deleted the mvidner:absolute-constant-lookup branch Jun 29, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.