Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SOLO.from_scvi_model when original model uses labels_key #1354

Merged
merged 3 commits into from Feb 15, 2022

Conversation

justjhong
Copy link
Contributor

Fixes #1163

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #1354 (0f7456d) into master (aab6094) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1354   +/-   ##
=======================================
  Coverage   90.86%   90.86%           
=======================================
  Files         109      109           
  Lines        8272     8274    +2     
=======================================
+ Hits         7516     7518    +2     
  Misses        756      756           
Impacted Files Coverage Δ
scvi/external/solo/_model.py 94.77% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aab6094...0f7456d. Read the comment docs.

@adamgayoso adamgayoso enabled auto-merge (squash) February 15, 2022 16:38
@adamgayoso adamgayoso merged commit d77d5c8 into master Feb 15, 2022
@adamgayoso adamgayoso deleted the jhong/1163 branch February 17, 2022 03:53
nrclaudio pushed a commit to nrclaudio/scvi-tools-tune that referenced this pull request Jun 21, 2022
…erse#1354)

* add failing test

* dummy labels in solo from_scvi_model

Co-authored-by: Adam Gayoso <adamgayoso@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create solo model from scvi model with cell-type labels.
2 participants