Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 馃幐 allow namespaced versions of "Date" #271

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@johngeorgewright
Copy link

johngeorgewright commented Mar 11, 2019

I'm trying to use this package to build schemas that include gapi.client.people types.

They use their own Date type:

        interface Date {
            /**
             * Day of month. Must be from 1 to 31 and valid for the year and month, or 0
             * if specifying a year/month where the day is not significant.
             */
            day?: number;
            /** Month of year. Must be from 1 to 12. */
            month?: number;
            /**
             * Year of date. Must be from 1 to 9999, or 0 if specifying a date without
             * a year.
             */
            year?: number;
        }

This does not build with typescript-json-schema, as it considers any interface with a name of Date to be a native Date.

This pull request will look for a "full qualified name" of Date instead.

@johngeorgewright johngeorgewright force-pushed the johngeorgewright:fix/custom-dates branch from cdf0d1e to 034ae61 Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.