Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http-client): prevent multiple authentication plugins #19

Closed
wants to merge 1 commit into from

Conversation

@Kocal
Copy link
Member

commented Oct 1, 2019

Si la méthode getHttpClient() était appelée deux fois, ça créait un nouvel PluginClient à chaque fois.

On pouvait donc avoir un PluginClient qui modifiait un PluginClient, qui modifiait un PluginClient, qui modifiait un PluginClient, etc ...

@Kocal Kocal requested review from RomulusED69 and tristanbes Oct 1, 2019
@Kocal

This comment has been minimized.

Copy link
Member Author

commented Oct 1, 2019

On ferme vu qu'on va migrer à Symfony HTTP Client

@Kocal Kocal closed this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.