Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sass): reject when fails #410

Closed
Kocal opened this issue Aug 7, 2019 · 1 comment

Comments

@Kocal
Copy link
Member

commented Aug 7, 2019

https://github.com/Yproximite/yProx-CLI/blob/master/lib/plugins/build/handlers/sass.ts#L44

it should call reject, otherwise yprox-cli won't stop when there is a Sass error:

Sélection_999(126)

@Kocal Kocal self-assigned this Aug 7, 2019

@tristanbes

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

suite à la remonté de @ClareO

Kocal added a commit that referenced this issue Aug 9, 2019

Kocal added a commit that referenced this issue Aug 9, 2019

@Kocal Kocal closed this in #411 Aug 9, 2019

Kocal added a commit that referenced this issue Aug 9, 2019

fix: fails properly when there is an error with Sass (#411)
* fix: make yProx-CLI fails properly when there is an error with Sass, close #410

* check code  too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.