Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update rollup-commonjs-plugin to fix an issue #393

Merged
merged 1 commit into from Jul 5, 2019

Conversation

Projects
None yet
1 participant
@Kocal
Copy link
Member

commented Jul 5, 2019

Pendant la migration vers yProx-CLI 3 sur yProx, j'ai remarqué que certains bundles n'étaient pas générés (polyfills, admin common):
Sélection_947

Après moultes heures de recherche dans Rollup, j'ai vu que ça venait du plugin CommonJS qui faisait un peu n'imp... :(
En forçant sa version via { resolutions": { "**/rollup-plugin-commonjs": "^10" } }, ça s'est remis à fonctionner :
Sélection_948

Je pense que ça a été corrigé par rollup/rollup-plugin-commonjs#349 (rollup/rollup-plugin-commonjs#341)

@Kocal Kocal changed the title build(deps): update rollup-commonjs-plugin build(deps): update rollup-commonjs-plugin to fix an issue Jul 5, 2019

@Kocal Kocal merged commit 95b72e5 into master Jul 5, 2019

4 of 9 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Header rules - yprox-cli No header rules processed
Details
Pages changed - yprox-cli 10 new files uploaded
Details
Redirect rules - yprox-cli No redirect rules processed
Details
Mixed content - yprox-cli No mixed content detected
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
netlify/yprox-cli/deploy-preview Deploy preview ready!
Details

@Kocal Kocal deleted the build/update-rollup-commonjs-plugin branch Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.