small ggdensitree modifications #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed branch.length default dangle -> align.tips added branch length to example added new example with heterochronous tips
|
thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Yu,
I am happy with the changes you made to my PR #253, except that I don't think that
branch.length="none"because the intended use of ggdensitree is to align tips vertically and horizontally from time scaled trees. The reason thatape::rmtreeproduces weird figures inggdensitreeis that the tips in those random trees will not have the same root-tip-distances in each tree.ape::rcoalworks better to make random trees forggdensitree.I changed the example to include branch lengths and added a second example that is hetrochronous.
I also changed the
dangleparameter toalign.tipsbecause I think that name is clearer.